From: Jan Kara <jack@suse.cz>
To: NeilBrown <neilb@suse.de>
Cc: Jan Kara <jack@suse.cz>, Jens Axboe <axboe@kernel.dk>,
reiserfs-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] reiserfs: don't use congestion_wait()
Date: Thu, 18 Nov 2021 11:45:44 +0100 [thread overview]
Message-ID: <20211118104544.GB13047@quack2.suse.cz> (raw)
In-Reply-To: <163712368225.13692.3419908086400748349@noble.neil.brown.name>
On Wed 17-11-21 15:34:42, NeilBrown wrote:
>
> Block devices do not, in general, report congestion any more, so this
> congestion_wait() is effectively just a sleep.
>
> It isn't entirely clear what is being waited for, but as we only wait
> when j_async_throttle is elevated, it seems reasonable to stop waiting
> when j_async_throttle becomes zero - or after the same timeout.
>
> So change to use wait_event_event_timeout() for waiting, and
> wake_up_var() to signal an end to waiting.
>
> Signed-off-by: NeilBrown <neilb@suse.de>
> ---
>
> I have no idea who might take this.... Jens and Jan have both landed
> reiserfs patches recently...
Yeah, I guess I can take this one. Honestly the whole code around
j_async_throttle looks a bit suspicious but your patch does not make it
worse so it looks safe to me :).
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2021-11-18 10:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 4:34 NeilBrown
2021-11-18 10:45 ` Jan Kara [this message]
2021-12-10 4:27 ` NeilBrown
2021-12-13 13:59 ` Jan Kara
2021-12-13 21:56 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211118104544.GB13047@quack2.suse.cz \
--to=jack@suse.cz \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=reiserfs-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®