Re: Linux 5.16-rc1

[Guenter Roeck <linux@roeck-us.net>]

On Thu, Nov 18, 2021 at 02:34:51PM -0800, Linus Torvalds wrote:
> On Thu, Nov 18, 2021 at 1:23 PM Guenter Roeck <linux@roeck-us.net> wrote:
> >
> > Like this ?
> 
> Ugh. Yes. Like that.
> 
> But now I have to go dig my eyes out with a rusty spoon and try to
> forget I ever saw that thing.
> 
> Because a thing of beauty it ain't.
> 
Hah.

> I would still hope somebody comes up with something prettier.
> 

It doesn't really have to be that fancy, but I suspect we'll end up
with something along that line. Kconfig doesn't support arithmetik,
so

config PAGE_SIZE
	int
	default 1 << PAGE_SHIFT

doesn't work, requiring the complex defaults.

Also,

	depends on !PAGE_SIZE || PAGE_SIZE < xxx

doesn't work either, making something like HAVE_PAGE_SIZE mandatory
unless PAGE_SIZE is made available for all architectures, which seems
excessive.

Of course,
	depends on !PPC
would be the simple solution.

Guenter