From: Sam Protsenko <semen.protsenko@linaro.org>
To: Guenter Roeck <linux@roeck-us.net>,
Wim Van Sebroeck <wim@linux-watchdog.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: [PATCH v4 11/12] watchdog: s3c2410: Remove superfluous err label
Date: Sun, 21 Nov 2021 18:56:46 +0200 [thread overview]
Message-ID: <20211121165647.26706-12-semen.protsenko@linaro.org> (raw)
In-Reply-To: <20211121165647.26706-1-semen.protsenko@linaro.org>
'err' label in probe function is not really need, it just returns.
Remove it and replace all 'goto' statements with actual returns in
place.
No functional change here, just a cleanup patch.
Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
---
Changes in v4:
- Added R-b tag by Guenter Roeck
Changes in v3:
- Added R-b tag by Krzysztof Kozlowski
Changes in v2:
- (none): it's a new patch
drivers/watchdog/s3c2410_wdt.c | 13 ++++---------
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/watchdog/s3c2410_wdt.c b/drivers/watchdog/s3c2410_wdt.c
index f31bc765a8a5..96aa5d9c6ed4 100644
--- a/drivers/watchdog/s3c2410_wdt.c
+++ b/drivers/watchdog/s3c2410_wdt.c
@@ -627,22 +627,18 @@ static int s3c2410wdt_probe(struct platform_device *pdev)
wdt_irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
if (wdt_irq == NULL) {
dev_err(dev, "no irq resource specified\n");
- ret = -ENOENT;
- goto err;
+ return -ENOENT;
}
/* get the memory region for the watchdog timer */
wdt->reg_base = devm_platform_ioremap_resource(pdev, 0);
- if (IS_ERR(wdt->reg_base)) {
- ret = PTR_ERR(wdt->reg_base);
- goto err;
- }
+ if (IS_ERR(wdt->reg_base))
+ return PTR_ERR(wdt->reg_base);
wdt->bus_clk = devm_clk_get(dev, "watchdog");
if (IS_ERR(wdt->bus_clk)) {
dev_err(dev, "failed to find bus clock\n");
- ret = PTR_ERR(wdt->bus_clk);
- goto err;
+ return PTR_ERR(wdt->bus_clk);
}
ret = clk_prepare_enable(wdt->bus_clk);
@@ -757,7 +753,6 @@ static int s3c2410wdt_probe(struct platform_device *pdev)
err_bus_clk:
clk_disable_unprepare(wdt->bus_clk);
- err:
return ret;
}
--
2.30.2
next prev parent reply other threads:[~2021-11-21 16:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-21 16:56 [PATCH v4 00/12] watchdog: s3c2410: Add Exynos850 support Sam Protsenko
2021-11-21 16:56 ` [PATCH v4 01/12] dt-bindings: watchdog: Require samsung,syscon-phandle for Exynos7 Sam Protsenko
2021-11-21 16:56 ` [PATCH v4 02/12] dt-bindings: watchdog: Document Exynos850 watchdog bindings Sam Protsenko
2021-11-21 16:56 ` [PATCH v4 03/12] watchdog: s3c2410: Fail probe if can't find valid timeout Sam Protsenko
2021-11-21 16:56 ` [PATCH v4 04/12] watchdog: s3c2410: Let kernel kick watchdog Sam Protsenko
2021-11-21 16:56 ` [PATCH v4 05/12] watchdog: s3c2410: Make reset disable register optional Sam Protsenko
2021-11-21 16:56 ` [PATCH v4 06/12] watchdog: s3c2410: Extract disable and mask code into separate functions Sam Protsenko
2021-11-21 16:56 ` [PATCH v4 07/12] watchdog: s3c2410: Implement a way to invert mask reg value Sam Protsenko
2021-11-21 16:56 ` [PATCH v4 08/12] watchdog: s3c2410: Add support for WDT counter enable register Sam Protsenko
2021-11-21 16:56 ` [PATCH v4 09/12] watchdog: s3c2410: Cleanup PMU related code Sam Protsenko
2021-11-23 16:06 ` Guenter Roeck
2021-11-23 16:17 ` Sam Protsenko
2021-11-23 22:33 ` Guenter Roeck
2021-11-23 23:30 ` Sam Protsenko
2021-11-27 22:52 ` Sam Protsenko
2021-11-28 17:56 ` Guenter Roeck
2021-11-28 19:18 ` Sam Protsenko
2021-11-21 16:56 ` [PATCH v4 10/12] watchdog: s3c2410: Support separate source clock Sam Protsenko
2021-11-21 16:56 ` Sam Protsenko [this message]
2021-11-21 16:56 ` [PATCH v4 12/12] watchdog: s3c2410: Add Exynos850 support Sam Protsenko
2021-11-22 15:14 ` Sam Protsenko
2021-11-23 16:12 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211121165647.26706-12-semen.protsenko@linaro.org \
--to=semen.protsenko@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®