From: cgel.zte@gmail.com
To: oliver@neukum.org
Cc: aliakc@web.de, lenehan@twibble.org, jejb@linux.ibm.com,
martin.petersen@oracle.com, dc395x@twibble.org,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Changcheng Deng <deng.changcheng@zte.com.cn>,
Zeal Robot <zealci@zte.com.cn>
Subject: [PATCH] scsi: dc395x: Use bitwise instead of arithmetic operator for flags
Date: Wed, 24 Nov 2021 03:23:14 +0000 [thread overview]
Message-ID: <20211124032314.35452-1-deng.changcheng@zte.com.cn> (raw)
From: Changcheng Deng <deng.changcheng@zte.com.cn>
Fix the following coccicheck warnings:
./drivers/scsi/dc395x.c: 1129: sum of probable bitmasks, consider |
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
---
drivers/scsi/dc395x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c
index 9b8796c9e634..854236d550e8 100644
--- a/drivers/scsi/dc395x.c
+++ b/drivers/scsi/dc395x.c
@@ -1126,7 +1126,7 @@ static void reset_dev_param(struct AdapterCtlBlk *acb)
list_for_each_entry(dcb, &acb->dcb_list, list) {
u8 period_index;
- dcb->sync_mode &= ~(SYNC_NEGO_DONE + WIDE_NEGO_DONE);
+ dcb->sync_mode &= ~(SYNC_NEGO_DONE | WIDE_NEGO_DONE);
dcb->sync_period = 0;
dcb->sync_offset = 0;
--
2.25.1
next reply other threads:[~2021-11-24 3:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-24 3:23 cgel.zte [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-03-09 3:39 Jiapeng Chong
2021-03-30 3:54 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211124032314.35452-1-deng.changcheng@zte.com.cn \
--to=cgel.zte@gmail.com \
--cc=aliakc@web.de \
--cc=dc395x@twibble.org \
--cc=deng.changcheng@zte.com.cn \
--cc=jejb@linux.ibm.com \
--cc=lenehan@twibble.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=oliver@neukum.org \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®