From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 806DFC433F5 for ; Fri, 26 Nov 2021 02:47:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359079AbhKZCup (ORCPT ); Thu, 25 Nov 2021 21:50:45 -0500 Received: from mail.kernel.org ([198.145.29.99]:50268 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358957AbhKZCp0 (ORCPT ); Thu, 25 Nov 2021 21:45:26 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3CF36611B0; Fri, 26 Nov 2021 02:36:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1637894183; bh=cUa1rjRlOgH3cNAuyeNmMadLMFU3Vu5drn9Z481Poio=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nDsCO1c4hJDfT3+JJxKVd91I0X4u34yJwQgPEloE8xXe3C+6vNudGie4XQKTDCUVD dhgsi33qUXGAKUR125gQc0GVc1G4/foCPbDQNEC4e+GcvM/HL7ks4WG7WaZsDbBYuC rrd8leTd6IHL/N9hFV+BUQh3somP3qsKH+qcwAvGN6hxbcO15PULlGv50pfwXwRhb0 gKYfTEvoU0oPJpBKbHmDsPBDUxGKsL9T/gwf3eb1o0PI55L+K7VHhEVlfqy8dmYPJ2 NxNFWGfrwPz1Dx/WJPyAiL7DGY3gaG9LXawzjSB4X09U6ff7XjZM9qXSQ9jem2VTug ylPSidgfkCM1w== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Manaf Meethalavalappu Pallikunhi , Thara Gopinath , "Rafael J . Wysocki" , Sasha Levin , rafael@kernel.org, daniel.lezcano@linaro.org, linux-pm@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 07/12] thermal: core: Reset previous low and high trip during thermal zone init Date: Thu, 25 Nov 2021 21:36:03 -0500 Message-Id: <20211126023611.443098-7-sashal@kernel.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211126023611.443098-1-sashal@kernel.org> References: <20211126023611.443098-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Manaf Meethalavalappu Pallikunhi [ Upstream commit 99b63316c39988039965693f5f43d8b4ccb1c86c ] During the suspend is in process, thermal_zone_device_update bails out thermal zone re-evaluation for any sensor trip violation without setting next valid trip to that sensor. It assumes during resume it will re-evaluate same thermal zone and update trip. But when it is in suspend temperature goes down and on resume path while updating thermal zone if temperature is less than previously violated trip, thermal zone set trip function evaluates the same previous high and previous low trip as new high and low trip. Since there is no change in high/low trip, it bails out from thermal zone set trip API without setting any trip. It leads to a case where sensor high trip or low trip is disabled forever even though thermal zone has a valid high or low trip. During thermal zone device init, reset thermal zone previous high and low trip. It resolves above mentioned scenario. Signed-off-by: Manaf Meethalavalappu Pallikunhi Reviewed-by: Thara Gopinath Signed-off-by: Rafael J. Wysocki Signed-off-by: Sasha Levin --- drivers/thermal/thermal_core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c index 94820f25a15ff..8374b8078b7df 100644 --- a/drivers/thermal/thermal_core.c +++ b/drivers/thermal/thermal_core.c @@ -457,6 +457,8 @@ static void thermal_zone_device_init(struct thermal_zone_device *tz) { struct thermal_instance *pos; tz->temperature = THERMAL_TEMP_INVALID; + tz->prev_low_trip = -INT_MAX; + tz->prev_high_trip = INT_MAX; list_for_each_entry(pos, &tz->thermal_instances, tz_node) pos->initialized = false; } -- 2.33.0