From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Cc: linux-pci@vger.kernel.org, bhelgaas@google.com,
linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] PCI: mt7621: declare 'mt7621_pci_ops' static
Date: Mon, 29 Nov 2021 18:06:54 +0000 [thread overview]
Message-ID: <20211129180653.GB26780@lpieralisi> (raw)
In-Reply-To: <20211117152952.12271-1-sergio.paracuellos@gmail.com>
On Wed, Nov 17, 2021 at 04:29:52PM +0100, Sergio Paracuellos wrote:
> Sparse complains about 'mt7621_pci_ops' symbol is not declared and asks if
> it should be declared as 'static' instead. Sparse is right. Hence declare
> symbol as static.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> ---
> drivers/pci/controller/pcie-mt7621.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to pci/mt7621, thanks.
Lorenzo
>
> diff --git a/drivers/pci/controller/pcie-mt7621.c b/drivers/pci/controller/pcie-mt7621.c
> index b60dfb45ef7b..4138c0e83513 100644
> --- a/drivers/pci/controller/pcie-mt7621.c
> +++ b/drivers/pci/controller/pcie-mt7621.c
> @@ -148,7 +148,7 @@ static void __iomem *mt7621_pcie_map_bus(struct pci_bus *bus,
> return pcie->base + RALINK_PCI_CONFIG_DATA + (where & 3);
> }
>
> -struct pci_ops mt7621_pci_ops = {
> +static struct pci_ops mt7621_pci_ops = {
> .map_bus = mt7621_pcie_map_bus,
> .read = pci_generic_config_read,
> .write = pci_generic_config_write,
> --
> 2.33.0
>
prev parent reply other threads:[~2021-11-29 18:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 15:29 Sergio Paracuellos
2021-11-17 21:14 ` Krzysztof Wilczyński
2021-11-18 5:08 ` Sergio Paracuellos
2021-11-29 18:06 ` Lorenzo Pieralisi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211129180653.GB26780@lpieralisi \
--to=lorenzo.pieralisi@arm.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lkp@intel.com \
--cc=sergio.paracuellos@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®