From: Ali El-Haj-Mahmoud <aaelhaj@google.com>
To: linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@aj.id.au>, Oskar Sneft <osk@google.com>,
Ali El-Haj-Mahmoud <aaelhaj@google.com>
Subject: [PATCH] S8036 DTS changes:
Date: Tue, 30 Nov 2021 12:57:40 -0500 [thread overview]
Message-ID: <20211130175740.2216591-1-aaelhaj@google.com> (raw)
- Allow VUART and SuperIO to coexist.
- Minor formatting.
---
.../linux-aspeed/aspeed-bmc-tyan-s8036.dts | 23 +++++++++++++++----
1 file changed, 18 insertions(+), 5 deletions(-)
diff --git a/meta-tyan/meta-s8036/recipes-kernel/linux/linux-aspeed/aspeed-bmc-tyan-s8036.dts b/meta-tyan/meta-s8036/recipes-kernel/linux/linux-aspeed/aspeed-bmc-tyan-s8036.dts
index 30b68ce89..7f650f6c8 100644
--- a/meta-tyan/meta-s8036/recipes-kernel/linux/linux-aspeed/aspeed-bmc-tyan-s8036.dts
+++ b/meta-tyan/meta-s8036/recipes-kernel/linux/linux-aspeed/aspeed-bmc-tyan-s8036.dts
@@ -127,10 +127,23 @@
status = "okay";
};
+&uart_routing {
+ status = "okay";
+};
+
&vuart {
status = "okay";
- aspeed,lpc-io-reg = <0x3f8>;
- aspeed,lpc-interrupts = <4 IRQ_TYPE_LEVEL_HIGH>;
+
+ /* We enable the VUART here, but leave it in a state that does
+ * not interfere with the SuperIO. The goal is to have both the
+ * VUART and the SuperIO available and decide at runtime whether
+ * the VUART should actually be used. For that reason, configure
+ * an "invalid" IO address and an IRQ that is not used by the
+ * BMC.
+ */
+
+ aspeed,lpc-io-reg = <0xffff>;
+ aspeed,lpc-interrupts = <15 IRQ_TYPE_LEVEL_HIGH>;
};
&lpc_ctrl {
@@ -340,7 +353,7 @@
&kcs1 {
status = "okay";
- aspeed,lpc-io-reg = <0xca8>;
+ aspeed,lpc-io-reg = <0xca8>;
};
&kcs3 {
@@ -385,7 +398,7 @@
/*A6*/ "",
/*A7*/ "",
/*B0-B7*/ "","","","","","","","",
- /*C0-C7*/ "","","","","","","","",
+ /*C0-C7*/ "","","","","","","","",
/*D0*/ "",
/*D1*/ "",
/*D2*/ "power-chassis-good", /* in: PWR_GOOD_LED -- Check if this is Z3?*/
@@ -447,6 +460,6 @@
/*AA5*/ "",
/*AA6*/ "",
/*AA7*/ "BMC_ASSERT_BMC_READY",
- /*AB0*/ "BMC_SPD_SEL",
+ /*AB0*/ "BMC_SPD_SEL",
/*AB1-AB7*/ "","","","","","","";
};
--
2.34.0.rc2.393.gf8c9666880-goog
next reply other threads:[~2021-11-30 17:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 17:57 Ali El-Haj-Mahmoud [this message]
2021-11-30 18:18 ` Ali El-Haj-Mahmoud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211130175740.2216591-1-aaelhaj@google.com \
--to=aaelhaj@google.com \
--cc=andrew@aj.id.au \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=osk@google.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®