From: Viresh Kumar <viresh.kumar@linaro.org>
To: Tang Yizhou <tangyizhou@huawei.com>
Cc: rafael.j.wysocki@intel.com, rafael@kernel.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] cpufreq: Fix a comment in cpufreq_policy_free
Date: Wed, 1 Dec 2021 12:17:59 +0530 [thread overview]
Message-ID: <20211201064759.2ak656yyr7wgxtj7@vireshk-i7> (raw)
In-Reply-To: <5a895a87-4eee-3dfd-5b86-af436929a068@huawei.com>
On 01-12-21, 14:39, Tang Yizhou wrote:
> On 2021/12/1 12:22, Viresh Kumar wrote:
> > On 30-11-21, 23:15, Tang Yizhou wrote:
> >> The comment is inconsistent with the block_notifier_call_chain() call,
> >> so fix it.
> >>
> >> Signed-off-by: Tang Yizhou <tangyizhou@huawei.com>
> >> ---
> >> drivers/cpufreq/cpufreq.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> >> index e338d2f010fe..8f753675e4a2 100644
> >> --- a/drivers/cpufreq/cpufreq.c
> >> +++ b/drivers/cpufreq/cpufreq.c
> >> @@ -1296,7 +1296,7 @@ static void cpufreq_policy_free(struct cpufreq_policy *policy)
> >>
> >> if (policy->max_freq_req) {
> >> /*
> >> - * CPUFREQ_CREATE_POLICY notification is sent only after
> >> + * CPUFREQ_REMOVE_POLICY notification is sent only after
> >
> > No, the earlier comment is correct. It says when the CREATE notification was
> > sent and so we need to do the remove here before removing max_freq_req.
>
> I see. I was confused at the first time. Perhaps it is better to both comment when
> CPUFREQ_CREATE_POLICY and CPUFREQ_REMOVE_POLICY notification is sent.
I am fine with elaborating the comment, sure. Please send another patch for
that.
--
viresh
next prev parent reply other threads:[~2021-12-01 6:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 15:15 [PATCH 0/2] cpufreq: Update function comment and document Tang Yizhou
2021-11-30 15:15 ` [PATCH 1/2] cpufreq: Fix a comment in cpufreq_policy_free Tang Yizhou
2021-12-01 4:22 ` Viresh Kumar
2021-12-01 6:39 ` Tang Yizhou
2021-12-01 6:47 ` Viresh Kumar [this message]
2021-11-30 15:15 ` [PATCH 2/2] doc/cpufreq: Update core.rst Tang Yizhou
2021-12-01 4:21 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211201064759.2ak656yyr7wgxtj7@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=tangyizhou@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®