mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Tom Zanussi <zanussi@kernel.org>,
	Yafang Shao <laoar.shao@gmail.com>,
	Sven Schnelle <svens@linux.ibm.com>
Subject: Re: [PATCH] tracing/histograms: String compares should not care about signed values
Date: Wed, 1 Dec 2021 10:20:05 -0500	[thread overview]
Message-ID: <20211201102005.474ef579@gandalf.local.home> (raw)
In-Reply-To: <20211201112100.23d4caafd8319e15073a41ed@kernel.org>

On Wed, 1 Dec 2021 11:21:00 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:

> On Tue, 30 Nov 2021 12:37:36 -0500
> Steven Rostedt <rostedt@goodmis.org> wrote:
> 
> > From 95f7262b44dc54fed8007cc3db8b39cbd16999c6 Mon Sep 17 00:00:00 2001
> > From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
> > Date: Tue, 30 Nov 2021 12:31:23 -0500
> > Subject: [PATCH] tracing/histograms: String compares should not care about
> >  signed values
> > 
> > When comparing two strings for the "onmatch" histogram trigger, fields
> > that are strings use string comparisons, which do not care about being
> > signed or not.
> > 
> > Do not fail to match two string fields if one is unsigned char array and
> > the other is a signed char array.
> > 
> > Link: https://lore.kernel.org/all/20211129123043.5cfd687a@gandalf.local.home/  
> 
> Looks good to me.
> 
> Review-by: Masami Hiramatsu <mhiramatsu@kernel.org>
> 
>

Thanks Masami. I'll add your reviewed-by before posting to Linus.

-- Steve

      reply	other threads:[~2021-12-01 15:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-30 17:37 Steven Rostedt
2021-12-01  2:21 ` Masami Hiramatsu
2021-12-01 15:20   ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211201102005.474ef579@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=laoar.shao@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=mingo@kernel.org \
    --cc=svens@linux.ibm.com \
    --cc=zanussi@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®