From: Ben Dai <ben.dai9703@gmail.com>
To: samitolvanen@google.com, ndesaulniers@google.com,
rostedt@goodmis.org, mingo@redhat.com
Cc: linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
Ben Dai <ben.dai@unisoc.com>
Subject: [PATCH] arm64: fix the address of syscall in arch_syscall_addr if CFI is enabled
Date: Fri, 3 Dec 2021 13:29:08 +0800 [thread overview]
Message-ID: <20211203052908.7467-1-ben.dai@unisoc.com> (raw)
With CONFIG_CFI_CLANG, the addresses in sys_call_table[] actually point to
jump instructions like "b __arm64_sys_*", and if CONFIG_LTO_CLANG_FULL is
enabled, the compiler will not generate a symbol for each jump. It causes
syscall tracer can't get symbol name in find_syscall_meta() and fail to
initialize.
To fix this problem, implement an strong definition of arch_syscall_addr()
to get the actual addresses of system calls.
Signed-off-by: Ben Dai <ben.dai@unisoc.com>
---
arch/arm64/kernel/syscall.c | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/arch/arm64/kernel/syscall.c b/arch/arm64/kernel/syscall.c
index 50a0f1a38e84..2b911603966b 100644
--- a/arch/arm64/kernel/syscall.c
+++ b/arch/arm64/kernel/syscall.c
@@ -12,6 +12,8 @@
#include <asm/debug-monitors.h>
#include <asm/exception.h>
#include <asm/fpsimd.h>
+#include <asm/insn.h>
+#include <asm/patching.h>
#include <asm/syscall.h>
#include <asm/thread_info.h>
#include <asm/unistd.h>
@@ -19,6 +21,25 @@
long compat_arm_syscall(struct pt_regs *regs, int scno);
long sys_ni_syscall(void);
+#ifdef CONFIG_CFI_CLANG
+unsigned long __init arch_syscall_addr(int nr)
+{
+ u32 insn;
+ unsigned long addr = (unsigned long)sys_call_table[nr];
+
+ /*
+ * Clang's CFI will replace the address of each system call function
+ * with the address of a jump table entry. In this case, the jump
+ * target address is the actual address of the system call.
+ */
+ aarch64_insn_read((void *)addr, &insn);
+ if (likely(aarch64_insn_is_b(insn)))
+ addr += aarch64_get_branch_offset(insn);
+
+ return addr;
+}
+#endif
+
static long do_ni_syscall(struct pt_regs *regs, int scno)
{
#ifdef CONFIG_COMPAT
--
2.17.0
next reply other threads:[~2021-12-03 5:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 5:29 Ben Dai [this message]
2021-12-03 11:12 ` Mark Rutland
2021-12-03 16:07 ` Sami Tolvanen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211203052908.7467-1-ben.dai@unisoc.com \
--to=ben.dai9703@gmail.com \
--cc=ben.dai@unisoc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mingo@redhat.com \
--cc=ndesaulniers@google.com \
--cc=rostedt@goodmis.org \
--cc=samitolvanen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®