From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11D14C433EF for ; Sat, 4 Dec 2021 12:18:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1384922AbhLDMWQ (ORCPT ); Sat, 4 Dec 2021 07:22:16 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:59370 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1384912AbhLDMWP (ORCPT ); Sat, 4 Dec 2021 07:22:15 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id D29791C0BB0; Sat, 4 Dec 2021 13:18:48 +0100 (CET) Date: Sat, 4 Dec 2021 13:18:47 +0100 From: Pavel Machek To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Vladimir Oltean , Richard Cochran , Jakub Kicinski , netdev@vger.kernel.org Subject: Re: [PATCH AUTOSEL 4.4 8/9] net: ptp: add a definition for the UDP port for IEEE 1588 general messages Message-ID: <20211204121847.GA15934@duo.ucw.cz> References: <20211130145402.947049-1-sashal@kernel.org> <20211130145402.947049-8-sashal@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ZGiS0Q5IWpPtfppv" Content-Disposition: inline In-Reply-To: <20211130145402.947049-8-sashal@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ZGiS0Q5IWpPtfppv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > [ Upstream commit ec15baec3272bbec576f2ce7ce47765a8e9b7b1c ] >=20 > As opposed to event messages (Sync, PdelayReq etc) which require > timestamping, general messages (Announce, FollowUp etc) do not. > In PTP they are part of different streams of data. >=20 > IEEE 1588-2008 Annex D.2 "UDP port numbers" states that the UDP > destination port assigned by IANA is 319 for event messages, and 320 for > general messages. Yet the kernel seems to be missing the definition for > general messages. This patch adds it. This does not fix any bug in 4.4, right? We do not need it in stable. Best regards, Pavel --=20 DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany --ZGiS0Q5IWpPtfppv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCYatcpwAKCRAw5/Bqldv6 8nNqAJ4th/eq5qbrpyI5Vf+tYwt3sW0y7QCgs6P2w9SCJGBpCPa2y5xg/0g2jPM= =pwrG -----END PGP SIGNATURE----- --ZGiS0Q5IWpPtfppv--