From: kernel test robot <lkp@intel.com>
To: Tero Kristo <tero.kristo@linux.intel.com>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org
Subject: [RFC PATCH t-kristo-pm] HID: bpf: hid_bpf_add_report() can be static
Date: Sat, 4 Dec 2021 23:28:14 +0800 [thread overview]
Message-ID: <20211204152814.GA74975@f51396ba56c0> (raw)
drivers/hid/hid-bpf.c:229:23: warning: symbol 'hid_bpf_add_report' was not declared. Should it be static?
drivers/hid/hid-bpf.c:257:6: warning: symbol 'hid_bpf_free_reports' was not declared. Should it be static?
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
hid-bpf.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/hid/hid-bpf.c b/drivers/hid/hid-bpf.c
index b46b68d54ea80..6b39c48d3d85c 100644
--- a/drivers/hid/hid-bpf.c
+++ b/drivers/hid/hid-bpf.c
@@ -226,9 +226,9 @@ struct hid_bpf_parser_and_data {
struct hid_bpf_report_enum report_enum[HID_REPORT_TYPES];
};
-struct hid_bpf_report *hid_bpf_add_report(struct hid_bpf_parser_and_data *data,
- unsigned int type, unsigned int id,
- unsigned int application)
+static struct hid_bpf_report *hid_bpf_add_report(struct hid_bpf_parser_and_data *data,
+ unsigned int type, unsigned int id,
+ unsigned int application)
{
struct hid_bpf_report_enum *report_enum = data->report_enum + type;
struct hid_bpf_report *report;
@@ -254,7 +254,7 @@ struct hid_bpf_report *hid_bpf_add_report(struct hid_bpf_parser_and_data *data,
return report;
}
-void hid_bpf_free_reports(struct hid_bpf_parser_and_data *data)
+static void hid_bpf_free_reports(struct hid_bpf_parser_and_data *data)
{
unsigned i, j;
reply other threads:[~2021-12-04 15:28 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211204152814.GA74975@f51396ba56c0 \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tero.kristo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®