From: Hector Martin <marcan@marcan.st>
To: Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>,
Marc Zyngier <maz@kernel.org>,
linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH 0/2] mmc: sdhci-pci-gli: GL9755: Quirks for Apple ARM platforms
Date: Tue, 7 Dec 2021 15:40:17 +0900 [thread overview]
Message-ID: <20211207064019.61444-1-marcan@marcan.st> (raw)
Hi folks,
This short series adds a few quirks needed to make the card readers in
Apple M1 Pro/Max MacBook laptops work properly.
The first patch should be straightforward; it just allows configuring
the CD/WP polarity based on device tree settings. There is already a
standard DT binding for this.
The second patch bugs me. I don't understand why this problem happens
on these machines, and not on e.g. x86 laptops (which presumably work
with this driver). 8/16-bit MMIO reads work fine on other PCIe devices
on these machines, so it is not a generalized problem with the PCIe
controller in these SoCs. The problem also happens when running macOS
(it also uses 32-bit reads). Ben, is there any chance you might know
of some vendor-specific knob somewhere that can fix this issue without
requiring the MMIO read workaround? Interestingly, 8/16-bit writes
work perfectly fine.
Hector Martin (2):
mmc: sdhci-pci-gli: GL9755: Support for CD/WP inversion on OF
platforms
mmc: sdhci-pci-gli: GL9755: Issue 8/16-bit MMIO reads as 32-bit reads.
drivers/mmc/host/sdhci-pci-gli.c | 38 ++++++++++++++++++++++++++++++--
1 file changed, 36 insertions(+), 2 deletions(-)
--
2.33.0
next reply other threads:[~2021-12-07 6:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 6:40 Hector Martin [this message]
2021-12-07 6:40 ` [PATCH 1/2] mmc: sdhci-pci-gli: GL9755: Support for CD/WP inversion on OF platforms Hector Martin
2021-12-07 6:40 ` [PATCH 2/2] mmc: sdhci-pci-gli: GL9755: Issue 8/16-bit MMIO reads as 32-bit reads Hector Martin
2021-12-09 12:19 ` Ben Chuang
2021-12-07 7:18 ` [PATCH 0/2] mmc: sdhci-pci-gli: GL9755: Quirks for Apple ARM platforms Hector Martin
[not found] ` <CACT4zj9Oy_Le8KzPS9WfH+Zx9Re7h0SOwkWFN+G5X1pCF3s3ZA@mail.gmail.com>
2021-12-07 14:10 ` Hector Martin
2021-12-08 11:18 ` Ben Chuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211207064019.61444-1-marcan@marcan.st \
--to=marcan@marcan.st \
--cc=adrian.hunter@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=maz@kernel.org \
--cc=sven@svenpeter.dev \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®