From: Christian Brauner <christian.brauner@ubuntu.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-fsdevel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] tracefs: Use d_inode() helper function to get the dentry inode
Date: Wed, 8 Dec 2021 16:33:09 +0100 [thread overview]
Message-ID: <20211208153309.egtqqql75czhc5ms@wittgenstein> (raw)
In-Reply-To: <20211208103052.706253b4@gandalf.local.home>
On Wed, Dec 08, 2021 at 10:30:52AM -0500, Steven Rostedt wrote:
> From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
>
> Instead of referencing the inode from a dentry via dentry->d_inode, use
> the helper function d_inode(dentry) instead. This is the considered the
> correct way to access it.
>
> Reported-by: Christian Brauner <christian.brauner@ubuntu.com>
> Reported: https://lore.kernel.org/all/20211208104454.nhxyvmmn6d2qhpwl@wittgenstein/
> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> ---
It's honestly not that big of a deal but yeah, looks good! :)
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
next prev parent reply other threads:[~2021-12-08 15:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 15:30 Steven Rostedt
2021-12-08 15:33 ` Christian Brauner [this message]
2021-12-08 15:41 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211208153309.egtqqql75czhc5ms@wittgenstein \
--to=christian.brauner@ubuntu.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®