mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Lukas Czerner <lczerner@redhat.com>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
	0day robot <lkp@intel.com>
Subject: [RFC PATCH] ext4: ext4_modify_primary_sb() can be static
Date: Sat, 11 Dec 2021 02:59:43 +0800	[thread overview]
Message-ID: <20211210185943.GA39725@eb09551c7cec> (raw)

fs/ext4/ioctl.c:45:5: warning: symbol 'ext4_modify_primary_sb' was not declared. Should it be static?
fs/ext4/ioctl.c:165:5: warning: symbol 'ext4_modify_superblocks_fn' was not declared. Should it be static?

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
 ioctl.c |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c
index 285862288ecb5..5f5c0e62e4d3d 100644
--- a/fs/ext4/ioctl.c
+++ b/fs/ext4/ioctl.c
@@ -42,9 +42,9 @@ static void ext4_sb_setlabel(struct ext4_super_block *es, const void *arg)
 	memcpy(es->s_volume_name, (char *)arg, EXT4_LABEL_MAX);
 }
 
-int ext4_modify_primary_sb(struct super_block *sb, handle_t *handle,
-			   ext4_modify_sb_callback func,
-			   const void *arg)
+static int ext4_modify_primary_sb(struct super_block *sb, handle_t *handle,
+				  ext4_modify_sb_callback func,
+				  const void *arg)
 {
 	int err = 0;
 	struct ext4_sb_info *sbi = EXT4_SB(sb);
@@ -162,9 +162,9 @@ static int ext4_update_backup_sb(struct super_block *sb, handle_t *handle,
  * This is safe because e2fsck will re-write them if there is a problem,
  * and we're very unlikely to ever need more than two backups.
  */
-int ext4_modify_superblocks_fn(struct super_block *sb,
-			       ext4_modify_sb_callback func,
-			       const void *arg)
+static int ext4_modify_superblocks_fn(struct super_block *sb,
+				      ext4_modify_sb_callback func,
+				      const void *arg)
 {
 	handle_t *handle;
 	ext4_group_t ngroups;

                 reply	other threads:[~2021-12-10 19:00 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211210185943.GA39725@eb09551c7cec \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    --cc=lczerner@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®