From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70A0EC433F5 for ; Sat, 11 Dec 2021 02:24:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241364AbhLKC2F (ORCPT ); Fri, 10 Dec 2021 21:28:05 -0500 Received: from mga01.intel.com ([192.55.52.88]:50828 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235456AbhLKC2E (ORCPT ); Fri, 10 Dec 2021 21:28:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1639189469; x=1670725469; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=eu+kAGLe2xaYb4m7w6k9myC6khXuaalJpz32iXYVDos=; b=jqn7U39OGbfJjIa/SQDQzB5kiRLuIAGRrrGhtcimHdgv2qXDrm4xMfFO KKcgJNlHYxtUJlpciXCelydOQPgV6cm/i/sOu39eaQQgs8TpQU7E/baH7 olafcQkgmcyROvGNKV4+P8o4IXeXzat9C3jJKCY5M95z5+sHpe0piane7 QfsJBdAn4SF4iNh48q3qY2VEwxt/Atrv9g/tHnMt2aWmX6Jjk9WKjuKBd lHXFhf70OT3nYk2d0e20KkVHR/vM1Fzu5rDS0seMqhbhihk+sjfGg43HJ D5CgPw1s5KfJ+3W1QyCxzMubXqFC/aIPgAUzSSbButvTVj4vEjSXA6eUB g==; X-IronPort-AV: E=McAfee;i="6200,9189,10194"; a="262613113" X-IronPort-AV: E=Sophos;i="5.88,197,1635231600"; d="scan'208";a="262613113" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Dec 2021 18:24:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,197,1635231600"; d="scan'208";a="565510812" Received: from lkp-server02.sh.intel.com (HELO 9e1e9f9b3bcb) ([10.239.97.151]) by fmsmga008.fm.intel.com with ESMTP; 10 Dec 2021 18:24:26 -0800 Received: from kbuild by 9e1e9f9b3bcb with local (Exim 4.92) (envelope-from ) id 1mvs3l-0003yw-KQ; Sat, 11 Dec 2021 02:24:25 +0000 Date: Sat, 11 Dec 2021 10:23:39 +0800 From: kernel test robot To: Namhyung Kim , Peter Zijlstra Cc: kbuild-all@lists.01.org, Ingo Molnar , Arnaldo Carvalho de Melo , Jiri Olsa , Mark Rutland , Alexander Shishkin , LKML , Stephane Eranian , Andi Kleen , Ian Rogers Subject: Re: [PATCH] perf/core: Fix cgroup event list management Message-ID: <202112111040.jKqB3uu1-lkp@intel.com> References: <20211211000652.1836690-1-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211211000652.1836690-1-namhyung@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Namhyung, I love your patch! Yet something to improve: [auto build test ERROR on tip/perf/core] [also build test ERROR on tip/master linux/master linus/master v5.16-rc4] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Namhyung-Kim/perf-core-Fix-cgroup-event-list-management/20211211-080810 base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git a9f4a6e92b3b319296fb078da2615f618f6cd80c config: csky-randconfig-r012-20211210 (https://download.01.org/0day-ci/archive/20211211/202112111040.jKqB3uu1-lkp@intel.com/config) compiler: csky-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/226bdbf0501464bc088d582c02d0495a61a68b7c git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Namhyung-Kim/perf-core-Fix-cgroup-event-list-management/20211211-080810 git checkout 226bdbf0501464bc088d582c02d0495a61a68b7c # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=csky SHELL=/bin/bash kernel/events/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): kernel/events/core.c: In function 'perf_remove_from_context': >> kernel/events/core.c:2391:63: error: 'struct perf_event_context' has no member named 'nr_cgroups' 2391 | if (!ctx->is_active && (!is_cgroup_event(event) || ctx->nr_cgroups > 1)) { | ^~ kernel/events/core.c: In function 'perf_install_in_context': kernel/events/core.c:2867:35: error: 'struct perf_event_context' has no member named 'nr_cgroups' 2867 | ctx->nr_events && (ctx->nr_cgroups || !is_cgroup_event(event))) { | ^~ vim +2391 kernel/events/core.c 2368 2369 /* 2370 * Remove the event from a task's (or a CPU's) list of events. 2371 * 2372 * If event->ctx is a cloned context, callers must make sure that 2373 * every task struct that event->ctx->task could possibly point to 2374 * remains valid. This is OK when called from perf_release since 2375 * that only calls us on the top-level context, which can't be a clone. 2376 * When called from perf_event_exit_task, it's OK because the 2377 * context has been detached from its task. 2378 */ 2379 static void perf_remove_from_context(struct perf_event *event, unsigned long flags) 2380 { 2381 struct perf_event_context *ctx = event->ctx; 2382 2383 lockdep_assert_held(&ctx->mutex); 2384 2385 /* 2386 * Because of perf_event_exit_task(), perf_remove_from_context() ought 2387 * to work in the face of TASK_TOMBSTONE, unlike every other 2388 * event_function_call() user. 2389 */ 2390 raw_spin_lock_irq(&ctx->lock); > 2391 if (!ctx->is_active && (!is_cgroup_event(event) || ctx->nr_cgroups > 1)) { 2392 __perf_remove_from_context(event, __get_cpu_context(ctx), 2393 ctx, (void *)flags); 2394 raw_spin_unlock_irq(&ctx->lock); 2395 return; 2396 } 2397 raw_spin_unlock_irq(&ctx->lock); 2398 2399 event_function_call(event, __perf_remove_from_context, (void *)flags); 2400 } 2401 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org