mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org,
	david@fromorbit.com, linux-kernel@vger.kernel.org,
	sandeen@sandeen.net, hch@lst.de
Subject: [GIT PULL] xfs: bug fixes for 5.16-rc4
Date: Sat, 11 Dec 2021 09:22:42 -0800	[thread overview]
Message-ID: <20211211172242.GH1218082@magnolia> (raw)

Hi Linus,

Please pull this branch for 5.16-rc4 that fixes a race between a
readonly remount process and other processes that hold a file IOLOCK on
files that previously experienced copy on write, that could result in
severe filesystem corruption if the filesystem is then remounted rw.  I
think this is fairly rare (since the only reliable reproducer I have
that fits the second criteria is the experimental xfs_scrub program),
but the race is clear, so we still need to fix this.

The branch merges cleanly against upstream as of a few minutes ago.
Please let me know if anything else strange happens during the merge
process.

--D

The following changes since commit e445976537ad139162980bee015b7364e5b64fff:

  xfs: remove incorrect ASSERT in xfs_rename (2021-12-01 17:27:48 -0800)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git tags/xfs-5.16-fixes-3

for you to fetch changes up to 089558bc7ba785c03815a49c89e28ad9b8de51f9:

  xfs: remove all COW fork extents when remounting readonly (2021-12-07 10:17:29 -0800)

----------------------------------------------------------------
Fixes for 5.16-rc4:
 - Fix a data corruption vector that can result from the ro remount
   process failing to clear all speculative preallocations from files
   and the rw remount process not noticing the incomplete cleanup.

----------------------------------------------------------------
Darrick J. Wong (1):
      xfs: remove all COW fork extents when remounting readonly

 fs/xfs/xfs_super.c | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

             reply	other threads:[~2021-12-11 17:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-11 17:22 Darrick J. Wong [this message]
2021-12-12  0:34 ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211211172242.GH1218082@magnolia \
    --to=djwong@kernel.org \
    --cc=david@fromorbit.com \
    --cc=hch@lst.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=sandeen@sandeen.net \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®