mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@kernel.org>
To: Frederic Weisbecker <frederic@kernel.org>
Cc: Neeraj Upadhyay <quic_neeraju@quicinc.com>,
	josh@joshtriplett.org, rostedt@goodmis.org,
	mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com,
	joel@joelfernandes.org, rcu@vger.kernel.org,
	linux-kernel@vger.kernel.org, urezki@gmail.com,
	boqun.feng@gmail.com
Subject: Re: [PATCH] rcu/exp: Fix check for idle context in rcu_exp_handler
Date: Mon, 13 Dec 2021 11:20:12 -0800	[thread overview]
Message-ID: <20211213192012.GQ641268@paulmck-ThinkPad-P17-Gen-1> (raw)
In-Reply-To: <20211213113455.GB782195@lothringen>

On Mon, Dec 13, 2021 at 12:34:55PM +0100, Frederic Weisbecker wrote:
> On Mon, Dec 13, 2021 at 11:40:24AM +0530, Neeraj Upadhyay wrote:
> > For PREEMPT_RCU, the rcu_exp_handler() function checks
> > whether the current CPU is in idle, by calling
> > rcu_dynticks_curr_cpu_in_eqs(). However, rcu_exp_handler()
> > is called in IPI handler context. So, it should be checking
> > the idle context using rcu_is_cpu_rrupt_from_idle(). Fix this
> > by using rcu_is_cpu_rrupt_from_idle() instead of
> > rcu_dynticks_curr_cpu_in_eqs(). Non-preempt configuration
> > already uses the correct check.
> > 
> > Signed-off-by: Neeraj Upadhyay <quic_neeraju@quicinc.com>
> 
> Reviewed-by: Frederic Weisbecker <frederic@kernel.org>

Queued for further review and testing, thank you both!

							Thanx, Paul

> > ---
> >  kernel/rcu/tree_exp.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/kernel/rcu/tree_exp.h b/kernel/rcu/tree_exp.h
> > index 237a79989aba..1568c8ef185b 100644
> > --- a/kernel/rcu/tree_exp.h
> > +++ b/kernel/rcu/tree_exp.h
> > @@ -656,7 +656,7 @@ static void rcu_exp_handler(void *unused)
> >  	 */
> >  	if (!depth) {
> >  		if (!(preempt_count() & (PREEMPT_MASK | SOFTIRQ_MASK)) ||
> > -		    rcu_dynticks_curr_cpu_in_eqs()) {
> > +		    rcu_is_cpu_rrupt_from_idle()) {
> >  			rcu_report_exp_rdp(rdp);
> >  		} else {
> >  			WRITE_ONCE(rdp->cpu_no_qs.b.exp, true);
> > -- 
> > 2.17.1
> > 

      reply	other threads:[~2021-12-13 19:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-13  6:10 Neeraj Upadhyay
2021-12-13 11:34 ` Frederic Weisbecker
2021-12-13 19:20   ` Paul E. McKenney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211213192012.GQ641268@paulmck-ThinkPad-P17-Gen-1 \
    --to=paulmck@kernel.org \
    --cc=boqun.feng@gmail.com \
    --cc=frederic@kernel.org \
    --cc=jiangshanlai@gmail.com \
    --cc=joel@joelfernandes.org \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=quic_neeraju@quicinc.com \
    --cc=rcu@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=urezki@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®