mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Philippe Schenker <philippe.schenker@toradex.com>
To: netdev@vger.kernel.org, Joakim Zhang <qiangqing.zhang@nxp.com>,
	"David S . Miller" <davem@davemloft.net>,
	Russell King <linux@armlinux.org.uk>,
	Andrew Lunn <andrew@lunn.ch>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
	Francesco Dolcini <francesco.dolcini@toradex.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Fabio Estevam <festevam@gmail.com>,
	Fugang Duan <fugang.duan@nxp.com>,
	Philippe Schenker <philippe.schenker@toradex.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH net-next 1/3] net: phy: add phy_reset_after_power_on() function
Date: Tue, 14 Dec 2021 13:16:36 +0100	[thread overview]
Message-ID: <20211214121638.138784-2-philippe.schenker@toradex.com> (raw)
In-Reply-To: <20211214121638.138784-1-philippe.schenker@toradex.com>

Some PHY requires a reset after being powered on (e.g. KSZ9131), add a
new function and related PHY_RST_AFTER_POWER_ON phy flag to be called
after the PHY regulator is enabled.

Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>
---

 drivers/net/phy/phy_device.c | 24 ++++++++++++++++++++++++
 include/linux/phy.h          |  2 ++
 2 files changed, 26 insertions(+)

diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index 74d8e1dc125f..bad836a7ee01 100644
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -1878,6 +1878,30 @@ int phy_reset_after_clk_enable(struct phy_device *phydev)
 }
 EXPORT_SYMBOL(phy_reset_after_clk_enable);
 
+/**
+ * phy_reset_after_power_on - perform a PHY reset if needed
+ * @phydev: target phy_device struct
+ *
+ * Description: Some PHYs or hardware design, need a reset after power was
+ *   enabled and rely on that software reset. This function evaluates the flags
+ *   and perform the reset if it's needed.
+ *   Returns < 0 on error, 0 if the phy wasn't reset and 1 if the phy was reset.
+ */
+int phy_reset_after_power_on(struct phy_device *phydev)
+{
+	if (!phydev || !phydev->drv)
+		return -ENODEV;
+
+	if (phydev->drv->flags & PHY_RST_AFTER_POWER_ON) {
+		phy_device_reset(phydev, 1);
+		phy_device_reset(phydev, 0);
+		return 1;
+	}
+
+	return 0;
+}
+EXPORT_SYMBOL(phy_reset_after_power_on);
+
 /* Generic PHY support and helper functions */
 
 /**
diff --git a/include/linux/phy.h b/include/linux/phy.h
index cbf03a5f9cf5..0d88cdc97dbd 100644
--- a/include/linux/phy.h
+++ b/include/linux/phy.h
@@ -80,6 +80,7 @@ extern const int phy_10gbit_features_array[1];
 #define PHY_IS_INTERNAL		0x00000001
 #define PHY_RST_AFTER_CLK_EN	0x00000002
 #define PHY_POLL_CABLE_TEST	0x00000004
+#define PHY_RST_AFTER_POWER_ON	0x00000008
 #define MDIO_DEVICE_IS_PHY	0x80000000
 
 /**
@@ -1499,6 +1500,7 @@ int phy_speed_up(struct phy_device *phydev);
 
 int phy_restart_aneg(struct phy_device *phydev);
 int phy_reset_after_clk_enable(struct phy_device *phydev);
+int phy_reset_after_power_on(struct phy_device *phydev);
 
 #if IS_ENABLED(CONFIG_PHYLIB)
 int phy_start_cable_test(struct phy_device *phydev,
-- 
2.34.1


  reply	other threads:[~2021-12-14 12:17 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-14 12:16 [PATCH net-next 0/3] Add Possiblity to Reset PHY After Power-up Philippe Schenker
2021-12-14 12:16 ` Philippe Schenker [this message]
2021-12-14 12:16 ` [PATCH net-next 2/3] net: phy: micrel: add reset-after-power-on flag to ksz9x31 phys Philippe Schenker
2021-12-14 12:16 ` [PATCH net-next 3/3] net: fec: reset phy on resume after power-up Philippe Schenker
2021-12-14 18:54   ` Andrew Lunn
2021-12-14 19:09     ` Russell King (Oracle)
2021-12-14 22:35     ` Francesco Dolcini
2021-12-15  9:36       ` Andrew Lunn
2021-12-15 10:29         ` Russell King (Oracle)
2021-12-15 11:01         ` Francesco Dolcini
2021-12-15 11:10           ` Francesco Dolcini
2021-12-15 19:34           ` Andrew Lunn
2021-12-15 19:48             ` Francesco Dolcini
2021-12-16  4:52           ` Joakim Zhang
2021-12-16  7:52             ` Francesco Dolcini
2021-12-16 10:24               ` Andrew Lunn
2021-12-16 11:24                 ` Francesco Dolcini
2021-12-16 11:28                   ` Andrew Lunn
2021-12-16 11:31                     ` Francesco Dolcini
2021-12-16 11:32                       ` Andrew Lunn
2021-12-15 10:25       ` Joakim Zhang
2021-12-14 12:23 ` [PATCH net-next 0/3] Add Possiblity to Reset PHY After Power-up Francesco Dolcini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211214121638.138784-2-philippe.schenker@toradex.com \
    --to=philippe.schenker@toradex.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=festevam@gmail.com \
    --cc=francesco.dolcini@toradex.com \
    --cc=fugang.duan@nxp.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=qiangqing.zhang@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®