mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Uladzislau Rezki (Sony)" <urezki@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>, RCU <rcu@vger.kernel.org>,
	"Paul E . McKenney" <paulmck@kernel.org>
Cc: Michal Hocko <mhocko@suse.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Daniel Axtens <dja@axtens.net>,
	Frederic Weisbecker <frederic@kernel.org>,
	Neeraj Upadhyay <neeraju@codeaurora.org>,
	Joel Fernandes <joel@joelfernandes.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	"Theodore Y . Ts'o" <tytso@mit.edu>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Uladzislau Rezki <urezki@gmail.com>,
	Oleksiy Avramchenko <oleksiy.avramchenko@sonymobile.com>,
	Uladzislau Rezki <uladzislau.rezki@sony.com>
Subject: [PATCH] fs: nfs: sysfs: Switch to kvfree_rcu() API
Date: Wed, 15 Dec 2021 12:18:40 +0100	[thread overview]
Message-ID: <20211215111845.2514-4-urezki@gmail.com> (raw)
In-Reply-To: <20211215111845.2514-1-urezki@gmail.com>

From: Uladzislau Rezki <uladzislau.rezki@sony.com>

Instead of invoking a synchronize_rcu() to free a pointer
after a grace period we can directly make use of new API
that does the same but in more efficient way.

TO: Trond Myklebust <trond.myklebust@hammerspace.com>
TO: linux-nfs@vger.kernel.org
Signed-off-by: Uladzislau Rezki <uladzislau.rezki@sony.com>
---
 fs/nfs/sysfs.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/fs/nfs/sysfs.c b/fs/nfs/sysfs.c
index 8cb70755e3c9..ff88d5d58e1e 100644
--- a/fs/nfs/sysfs.c
+++ b/fs/nfs/sysfs.c
@@ -113,10 +113,9 @@ static ssize_t nfs_netns_identifier_store(struct kobject *kobj,
 	if (!p)
 		return -ENOMEM;
 	old = rcu_dereference_protected(xchg(&c->identifier, (char __rcu *)p), 1);
-	if (old) {
-		synchronize_rcu();
-		kfree(old);
-	}
+	if (old)
+		kvfree_rcu(old);
+
 	return count;
 }
 
-- 
2.30.2


  parent reply	other threads:[~2021-12-15 11:19 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-15 11:18 [PATCH] drdb: " Uladzislau Rezki (Sony)
2021-12-15 11:18 ` [PATCH RESEND] ext4: Replace ext4_kvfree_array_rcu() by " Uladzislau Rezki (Sony)
2021-12-15 19:40   ` Uladzislau Rezki
2021-12-15 11:18 ` [PATCH RESEND] ext4: Switch to " Uladzislau Rezki (Sony)
2021-12-15 19:41   ` Uladzislau Rezki
2021-12-15 11:18 ` Uladzislau Rezki (Sony) [this message]
2021-12-15 19:42   ` [PATCH] fs: nfs: sysfs: " Uladzislau Rezki
2021-12-15 11:18 ` [PATCH] mfd: dln2: " Uladzislau Rezki (Sony)
2021-12-15 19:43   ` Uladzislau Rezki
2021-12-16 17:01     ` Lee Jones
2021-12-17 15:06       ` Uladzislau Rezki
2021-12-15 11:18 ` [PATCH] misc: vmw_vmci: " Uladzislau Rezki (Sony)
2021-12-15 19:45   ` Uladzislau Rezki
2021-12-15 11:18 ` [PATCH] mlxsw: core: " Uladzislau Rezki (Sony)
2021-12-15 19:46   ` Uladzislau Rezki
2021-12-15 23:38     ` Jakub Kicinski
2021-12-15 11:18 ` [PATCH] RDMA/hfi1: " Uladzislau Rezki (Sony)
2021-12-15 19:47   ` Uladzislau Rezki
2021-12-15 19:49     ` Jason Gunthorpe
2021-12-15 20:51       ` Uladzislau Rezki
2021-12-15 11:18 ` [PATCH] scsi: core: " Uladzislau Rezki (Sony)
2021-12-15 19:48   ` Uladzislau Rezki
2021-12-15 19:38 ` [PATCH] drdb: " Uladzislau Rezki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211215111845.2514-4-urezki@gmail.com \
    --to=urezki@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=bigeasy@linutronix.de \
    --cc=dja@axtens.net \
    --cc=frederic@kernel.org \
    --cc=joel@joelfernandes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhocko@suse.com \
    --cc=neeraju@codeaurora.org \
    --cc=oleksiy.avramchenko@sonymobile.com \
    --cc=paulmck@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rcu@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tytso@mit.edu \
    --cc=uladzislau.rezki@sony.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®