From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1873C433FE for ; Wed, 15 Dec 2021 13:57:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243094AbhLON5z (ORCPT ); Wed, 15 Dec 2021 08:57:55 -0500 Received: from mga14.intel.com ([192.55.52.115]:25583 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243074AbhLON5y (ORCPT ); Wed, 15 Dec 2021 08:57:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1639576674; x=1671112674; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=pqrizbWMDB8CuvAtjODNYAP/gTLp/24Si3iA4T53x4o=; b=P8nRtQ01zhy0ShooRaRtdW40Dn44lybIrF8IDNjLhZUuphJUv2+UTCz4 zbwG5IB+a12yo2FAFMNZhjsCbfoLXamqjr0nmiFxQuqkwu+zAA+2Fxfg5 RGzEZx0NeGK1q6Hk9jvq2aLdd+NtZNfwVJmXH+bID2yJ4ilVohulrFWIU yk5+soRDyp4lb4LFtEZYPRDcb3DX6wqx821yIUfTKPLSJIgIDRK7ASdHT aBbd0J7ZjbeFfNLKV4yzpTBSNEidA2ZMnbBN8or+r/TcCOT+b3q8AcXvr kdXrLU4P05OzbbqTdLx8v1s1AvvDWQIXrLd+ZJHx7Qyxs8CxwIJK1789u w==; X-IronPort-AV: E=McAfee;i="6200,9189,10198"; a="239450413" X-IronPort-AV: E=Sophos;i="5.88,207,1635231600"; d="scan'208";a="239450413" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Dec 2021 05:57:53 -0800 X-IronPort-AV: E=Sophos;i="5.88,207,1635231600"; d="scan'208";a="682502782" Received: from sannilnx.jer.intel.com ([10.12.231.79]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Dec 2021 05:57:50 -0800 From: Alexander Usyskin To: Greg Kroah-Hartman , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , Daniel Vetter Cc: Tomas Winkler , Alexander Usyskin , Vitaly Lubart , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/5] mei: gsc: setup char driver alive in spite of firmware handshake failure Date: Wed, 15 Dec 2021 15:56:20 +0200 Message-Id: <20211215135622.1060229-4-alexander.usyskin@intel.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20211215135622.1060229-1-alexander.usyskin@intel.com> References: <20211215135622.1060229-1-alexander.usyskin@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Continue to char device setup in spite of firmware handshake failure. In order to provide access to the firmware status registers and other information are valuable for debug and manufacturing. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/gsc-me.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/misc/mei/gsc-me.c b/drivers/misc/mei/gsc-me.c index 901d6e0ce6cd..c6bf869d910b 100644 --- a/drivers/misc/mei/gsc-me.c +++ b/drivers/misc/mei/gsc-me.c @@ -86,11 +86,12 @@ static int mei_gsc_probe(struct platform_device *platdev) pm_runtime_set_active(device); pm_runtime_enable(device); - if (mei_start(dev)) { - dev_err(device, "init hw failure.\n"); - ret = -ENODEV; - goto err; - } + /* Continue to char device setup in spite of firmware handshake failure. + * In order to provide access to the firmware status registers to the user + * space via sysfs. + */ + if (mei_start(dev)) + dev_warn(device, "init hw failure.\n"); pm_runtime_set_autosuspend_delay(device, MEI_GSC_RPM_TIMEOUT); pm_runtime_use_autosuspend(device); -- 2.32.0