From: Pratyush Yadav <p.yadav@ti.com>
To: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Cc: Tudor Ambarus <tudor.ambarus@microchip.com>,
Michael Walle <michael@walle.cc>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] mtd: spi-nor: micron-st: make mt25ql02g/mt25qu02g match more specific, add 4B opcodes
Date: Fri, 17 Dec 2021 16:07:13 +0530 [thread overview]
Message-ID: <20211217103711.vrwx45spgzl73emp@ti.com> (raw)
In-Reply-To: <fd52c394b8c5f727b04166ca29e893baa940e2a5.camel@ew.tq-group.com>
On 17/12/21 11:07AM, Matthias Schiffer wrote:
> On Fri, 2021-12-17 at 00:22 +0530, Pratyush Yadav wrote:
> > Hi Matthias,
> >
> > On 07/10/21 02:08PM, Matthias Schiffer wrote:
> > > Change the mt25ql02g/mt25qu02g entries to include
> > > SPI_NOR_4B_OPCODES. In
> > > addition, the SPI_NOR_DUAL_READ flag is added to mt25ql02g; this
> > > seems
> > > to have been an accidental omission, as mt25ql02g and mt25qu02g
> > > should
> > > support the same features.
> >
> > The way flags are specified are changed a bit. See [0]. Please re-
> > roll
> > your patch to use the new flag types. If this flash supports SFDP
> > you
> > should ideally just need to set the sfdp flag to true and the core
> > should take care of the rest. Test reports with the new changes would
> > be
> > much appreciated :-)
>
> Will do. Is there an easy way to check which features the kernel
> detected from the SFDP with the new code?
Hm, I don't think so. I think you would have to add debug prints in the
driver to know which flags were discovered by SFDP.
--
Regards,
Pratyush Yadav
Texas Instruments Inc.
prev parent reply other threads:[~2021-12-17 10:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 12:08 Matthias Schiffer
2021-10-07 12:08 ` [PATCH v2 2/2] mtd: spi-nor: micron-st: add support for mt25ql01g and mt25qu01g Matthias Schiffer
2021-12-02 9:20 ` [PATCH v2 1/2] mtd: spi-nor: micron-st: make mt25ql02g/mt25qu02g match more specific, add 4B opcodes Matthias Schiffer
2021-12-16 18:52 ` Pratyush Yadav
2021-12-17 10:07 ` Matthias Schiffer
2021-12-17 10:37 ` Pratyush Yadav [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211217103711.vrwx45spgzl73emp@ti.com \
--to=p.yadav@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®