From: Pratyush Yadav <p.yadav@ti.com>
To: Tudor Ambarus <tudor.ambarus@microchip.com>
Cc: <miquel.raynal@bootlin.com>, <richard@nod.at>, <vigneshr@ti.com>,
<zhuohao@chromium.org>, <michael@walle.cc>,
<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] mtd: core: Remove partid and partname debugfs files
Date: Mon, 20 Dec 2021 18:37:45 +0530 [thread overview]
Message-ID: <20211220130743.jil62qbyb5lgds6p@ti.com> (raw)
In-Reply-To: <20211217122636.474976-3-tudor.ambarus@microchip.com>
On 17/12/21 02:26PM, Tudor Ambarus wrote:
> partid and partname debugfs file are no longer used in mtd, remove
> dead code.
Hmm, spi-nor was the only user? Quick grepping does confirm that.
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> ---
> drivers/mtd/mtdcore.c | 35 +----------------------------------
> include/linux/mtd/mtd.h | 3 ---
> 2 files changed, 1 insertion(+), 37 deletions(-)
>
> diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
> index 9186268d361b..1977755fc955 100644
> --- a/drivers/mtd/mtdcore.c
> +++ b/drivers/mtd/mtdcore.c
> @@ -336,49 +336,16 @@ static const struct device_type mtd_devtype = {
> .release = mtd_release,
> };
>
> -static int mtd_partid_debug_show(struct seq_file *s, void *p)
> -{
> - struct mtd_info *mtd = s->private;
> -
> - seq_printf(s, "%s\n", mtd->dbg.partid);
> -
> - return 0;
> -}
> -
> -DEFINE_SHOW_ATTRIBUTE(mtd_partid_debug);
> -
> -static int mtd_partname_debug_show(struct seq_file *s, void *p)
> -{
> - struct mtd_info *mtd = s->private;
> -
> - seq_printf(s, "%s\n", mtd->dbg.partname);
> -
> - return 0;
> -}
> -
> -DEFINE_SHOW_ATTRIBUTE(mtd_partname_debug);
> -
> static struct dentry *dfs_dir_mtd;
>
> static void mtd_debugfs_populate(struct mtd_info *mtd)
> {
> - struct mtd_info *master = mtd_get_master(mtd);
> struct device *dev = &mtd->dev;
> - struct dentry *root;
>
> if (IS_ERR_OR_NULL(dfs_dir_mtd))
> return;
>
> - root = debugfs_create_dir(dev_name(dev), dfs_dir_mtd);
> - mtd->dbg.dfs_dir = root;
> -
> - if (master->dbg.partid)
> - debugfs_create_file("partid", 0400, root, master,
> - &mtd_partid_debug_fops);
> -
> - if (master->dbg.partname)
> - debugfs_create_file("partname", 0400, root, master,
> - &mtd_partname_debug_fops);
> + mtd->dbg.dfs_dir = debugfs_create_dir(dev_name(dev), dfs_dir_mtd);
What is the point of having creating the directory if there is not going
to be anything in it at all? I think we should drop the entire thing if
there is no intention of using it.
> }
>
> #ifndef CONFIG_MMU
> diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h
> index f5e7dfc2e4e9..00cb269d0261 100644
> --- a/include/linux/mtd/mtd.h
> +++ b/include/linux/mtd/mtd.h
> @@ -188,9 +188,6 @@ struct module; /* only needed for owner field in mtd_info */
> */
> struct mtd_debug_info {
> struct dentry *dfs_dir;
> -
> - const char *partname;
> - const char *partid;
> };
>
> /**
> --
> 2.25.1
>
--
Regards,
Pratyush Yadav
Texas Instruments Inc.
next prev parent reply other threads:[~2021-12-20 13:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 12:26 [PATCH 0/2] " Tudor Ambarus
2021-12-17 12:26 ` [PATCH 1/2] mtd: spi-nor: Remove debugfs entries that duplicate sysfs entries Tudor Ambarus
2021-12-20 12:59 ` Pratyush Yadav
2021-12-17 12:26 ` [PATCH 2/2] mtd: core: Remove partid and partname debugfs files Tudor Ambarus
2021-12-20 13:07 ` Pratyush Yadav [this message]
2021-12-20 13:23 ` Tudor.Ambarus
2021-12-20 19:05 ` Pratyush Yadav
2021-12-20 13:05 ` [PATCH 0/2] " Michael Walle
2021-12-29 8:27 ` (subset) " Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211220130743.jil62qbyb5lgds6p@ti.com \
--to=p.yadav@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
--cc=zhuohao@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®