From: Remi Pommarel <repk@triplefau.lt>
To: netdev@vger.kernel.org
Cc: Roopa Prabhu <roopa@nvidia.com>,
Nikolay Aleksandrov <nikolay@nvidia.com>,
Arnd Bergmann <arnd@arndb.de>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
Remi Pommarel <repk@triplefau.lt>
Subject: [PATCH net 0/2] Fix SIOCGIFBR/SIOCSIFBR ioctl
Date: Thu, 23 Dec 2021 16:31:37 +0100 [thread overview]
Message-ID: <20211223153139.7661-1-repk@triplefau.lt> (raw)
SIOC{G,S}IFBR ioctls have been broken since [0], as discussed here [1]
the intent was to get them working in compat mode.
This serie is gathering patch from [2] with the one from [3].
The first patch fixes the ioctl usage so it can be backported to stable
kernel while the second one adds proper support for those ioctl in
compat mode.
This has been tested with busybox's brctl as below.
Before this serie
- 64-bit brctl:
$ brctl show
bridge name bridge id STP enabled interfaces
brctl: can't get bridge name for index 0: No such device or address
- 32-bit brctl on CONFIG_COMPAT=y kernel:
$ brctl show
brctl: SIOCGIFBR: Invalid argument
With first patch of this serie
- 64-bit brctl
$ brctl show
bridge name bridge id STP enabled interfaces
br0 8000.000000000000 no
- 32-bit brctl on CONFIG_COMPAT=y kernel
$ brctl show
brctl: SIOCGIFBR: Invalid argument
With both patches
- 64-bit brctl
$ brctl show
bridge name bridge id STP enabled interfaces
br0 8000.000000000000 no
- 32-bit brctl on CONFIG_COMPAT=y kernel
$ brctl show
bridge name bridge id STP enabled interfaces
br0 8000.000000000000 no
[0] commit 561d8352818f ("bridge: use ndo_siocdevprivate")
[1] https://lkml.org/lkml/2021/12/22/805
[2] https://lkml.org/lkml/2021/12/22/743
[3] https://lkml.org/lkml/2021/12/23/212
Thanks,
Remi Pommarel (2):
net: bridge: fix ioctl old_deviceless bridge argument
net: bridge: Get SIOCGIFBR/SIOCSIFBR ioctl working in compat mode
net/bridge/br_ioctl.c | 75 ++++++++++++++++++++++++++++---------------
net/socket.c | 20 ++----------
2 files changed, 52 insertions(+), 43 deletions(-)
--
2.33.0
next reply other threads:[~2021-12-23 15:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-23 15:31 Remi Pommarel [this message]
2021-12-23 15:31 ` [PATCH net 1/2] net: bridge: fix ioctl old_deviceless bridge argument Remi Pommarel
2021-12-23 15:31 ` [PATCH net 2/2] net: bridge: Get SIOCGIFBR/SIOCSIFBR ioctl working in compat mode Remi Pommarel
2021-12-23 16:59 ` Jakub Kicinski
2021-12-23 17:50 ` Remi Pommarel
2021-12-23 17:53 ` Jakub Kicinski
2021-12-23 18:05 ` Remi Pommarel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211223153139.7661-1-repk@triplefau.lt \
--to=repk@triplefau.lt \
--cc=arnd@arndb.de \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®