From: Richard Cochran <richardcochran@gmail.com>
To: "Radu Pirea (NXP OSS)" <radu-nicolae.pirea@oss.nxp.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
christian.herber@nxp.com, andrew@lunn.ch, hkallweit1@gmail.com,
linux@armlinux.org.uk, davem@davemloft.net, kuba@kernel.org
Subject: Re: [PATCH v2 2/2] phy: nxp-c45-tja11xx: read the tx timestamp without lock
Date: Thu, 23 Dec 2021 12:24:17 -0800 [thread overview]
Message-ID: <20211223202417.GC29492@hoboy.vegasvil.org> (raw)
In-Reply-To: <20211222213453.969005-3-radu-nicolae.pirea@oss.nxp.com>
On Wed, Dec 22, 2021 at 11:34:53PM +0200, Radu Pirea (NXP OSS) wrote:
> Reading the tx timestamps can be done in parallel with adjusting the LTC
> value.
>
> Calls to nxp_c45_get_hwtxts() are always serialised. If the phy
> interrupt is enabled, .do_aux_work() will not call nxp_c45_get_hwtxts.
Reviewing the code, I see what you mean. However, the serialization
is completely non-obvious, and future changes to the driver could
easily spoil the implicit serialization. Given that the mutex is not
highly contended, I suggest dropping this patch in order to
future-proof the driver.
Thanks,
Richard
next prev parent reply other threads:[~2021-12-23 20:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-22 21:34 [PATCH v2 0/2] TJA1103 perout and extts Radu Pirea (NXP OSS)
2021-12-22 21:34 ` [PATCH v2 1/2] phy: nxp-c45-tja11xx: add extts and perout support Radu Pirea (NXP OSS)
2021-12-22 21:34 ` [PATCH v2 2/2] phy: nxp-c45-tja11xx: read the tx timestamp without lock Radu Pirea (NXP OSS)
2021-12-23 20:24 ` Richard Cochran [this message]
2022-01-03 12:28 ` Radu Nicolae Pirea (NXP OSS)
2021-12-23 20:20 ` [PATCH v2 0/2] TJA1103 perout and extts Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211223202417.GC29492@hoboy.vegasvil.org \
--to=richardcochran@gmail.com \
--cc=andrew@lunn.ch \
--cc=christian.herber@nxp.com \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=radu-nicolae.pirea@oss.nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®