From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89BD6C433F5 for ; Mon, 27 Dec 2021 19:07:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233213AbhL0THy (ORCPT ); Mon, 27 Dec 2021 14:07:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230484AbhL0TGt (ORCPT ); Mon, 27 Dec 2021 14:06:49 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0CFFC061D5E; Mon, 27 Dec 2021 11:06:45 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 91194B81141; Mon, 27 Dec 2021 19:06:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F58DC36AEB; Mon, 27 Dec 2021 19:06:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1640632003; bh=lBTqxLmvB/WOYzwlcaOetSC8KuIrbI3m3B+bQ56rGN4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XAap15nqSkVKL85uZr/mJ5lgm0lBNEyhiOt40huue794vElcOQUSxagSZgS2dRkv5 NdhopwlN9pcdFZ/osYsZ8FAmyBOQ9wuA2cNUiXecWqsRmW+mAhnoJatkgVDDyI5D0O Qscs+Qmlm/hsxTQtrbeizX6GrYRHw5BRvNHeyXMjuC7B1R+eNbcSRzmSABzju1iOWs mG4iAeK/wg+4vaT9QmChFHai6fC1wvk3YI6ogJ9LFdyVwS0NJZoh6E8L122tFDg3iB 4ZPRLfBstVuoHfdC7bhl3efPfLleBbsAXgroeQlkgvW4ETbHswTjR5lirbtpUA1dh3 YHkEQk3LikpKg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Lin Ma , Hanjie Wu , "David S . Miller" , Sasha Levin , jreuter@yaina.de, kuba@kernel.org, linux-hams@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 2/4] ax25: NPD bug when detaching AX25 device Date: Mon, 27 Dec 2021 14:06:27 -0500 Message-Id: <20211227190629.1043445-2-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20211227190629.1043445-1-sashal@kernel.org> References: <20211227190629.1043445-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lin Ma [ Upstream commit 1ade48d0c27d5da1ccf4b583d8c5fc8b534a3ac8 ] The existing cleanup routine implementation is not well synchronized with the syscall routine. When a device is detaching, below race could occur. static int ax25_sendmsg(...) { ... lock_sock() ax25 = sk_to_ax25(sk); if (ax25->ax25_dev == NULL) // CHECK ... ax25_queue_xmit(skb, ax25->ax25_dev->dev); // USE ... } static void ax25_kill_by_device(...) { ... if (s->ax25_dev == ax25_dev) { s->ax25_dev = NULL; ... } Other syscall functions like ax25_getsockopt, ax25_getname, ax25_info_show also suffer from similar races. To fix them, this patch introduce lock_sock() into ax25_kill_by_device in order to guarantee that the nullify action in cleanup routine cannot proceed when another socket request is pending. Signed-off-by: Hanjie Wu Signed-off-by: Lin Ma Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/ax25/af_ax25.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/ax25/af_ax25.c b/net/ax25/af_ax25.c index 6915eebc7a4a9..0232afd9d9c3c 100644 --- a/net/ax25/af_ax25.c +++ b/net/ax25/af_ax25.c @@ -88,8 +88,10 @@ static void ax25_kill_by_device(struct net_device *dev) again: ax25_for_each(s, &ax25_list) { if (s->ax25_dev == ax25_dev) { - s->ax25_dev = NULL; spin_unlock_bh(&ax25_list_lock); + lock_sock(s->sk); + s->ax25_dev = NULL; + release_sock(s->sk); ax25_disconnect(s, ENETUNREACH); spin_lock_bh(&ax25_list_lock); -- 2.34.1