From: kernel test robot <lkp@intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: kbuild-all@lists.01.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [driver-core:debugfs_cleanup 4/5] fs/d_path.c:59 prepend() warn: unsigned 'p->len' is never less than zero.
Date: Sat, 1 Jan 2022 01:08:41 +0800 [thread overview]
Message-ID: <202201010156.bJvO7Gaw-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git debugfs_cleanup
head: a04bbe0a2c7e98669e11a47f94e53dd8228bbeba
commit: e95d5bed5d58c2f5352969369827e7135fa2261e [4/5] fs: make d_path-like functions all have unsigned size
config: i386-randconfig-m031-20211228 (https://download.01.org/0day-ci/archive/20220101/202201010156.bJvO7Gaw-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
smatch warnings:
fs/d_path.c:59 prepend() warn: unsigned 'p->len' is never less than zero.
vim +59 fs/d_path.c
b0cfcdd9b9672e Linus Torvalds 2021-07-16 55
b0cfcdd9b9672e Linus Torvalds 2021-07-16 56 static bool prepend(struct prepend_buffer *p, const char *str, int namelen)
b0cfcdd9b9672e Linus Torvalds 2021-07-16 57 {
b0cfcdd9b9672e Linus Torvalds 2021-07-16 58 // Already overflowed?
b0cfcdd9b9672e Linus Torvalds 2021-07-16 @59 if (p->len < 0)
b0cfcdd9b9672e Linus Torvalds 2021-07-16 60 return false;
b0cfcdd9b9672e Linus Torvalds 2021-07-16 61
b0cfcdd9b9672e Linus Torvalds 2021-07-16 62 // Will overflow?
b0cfcdd9b9672e Linus Torvalds 2021-07-16 63 if (p->len < namelen) {
b0cfcdd9b9672e Linus Torvalds 2021-07-16 64 // Fill as much as possible from the end of the name
b0cfcdd9b9672e Linus Torvalds 2021-07-16 65 str += namelen - p->len;
b0cfcdd9b9672e Linus Torvalds 2021-07-16 66 p->buf -= p->len;
b0cfcdd9b9672e Linus Torvalds 2021-07-16 67 prepend_copy(p->buf, str, p->len);
b0cfcdd9b9672e Linus Torvalds 2021-07-16 68 p->len = -1;
b0cfcdd9b9672e Linus Torvalds 2021-07-16 69 return false;
b0cfcdd9b9672e Linus Torvalds 2021-07-16 70 }
b0cfcdd9b9672e Linus Torvalds 2021-07-16 71
b0cfcdd9b9672e Linus Torvalds 2021-07-16 72 // Fits fully
ad08ae586586ea Al Viro 2021-05-12 73 p->len -= namelen;
ad08ae586586ea Al Viro 2021-05-12 74 p->buf -= namelen;
b0cfcdd9b9672e Linus Torvalds 2021-07-16 75 return prepend_copy(p->buf, str, namelen);
7a5cf791a74764 Al Viro 2018-03-05 76 }
7a5cf791a74764 Al Viro 2018-03-05 77
:::::: The code at line 59 was first introduced by commit
:::::: b0cfcdd9b9672ea90642f33d6c0dd8516553adf2 d_path: make 'prepend()' fill up the buffer exactly on overflow
:::::: TO: Linus Torvalds <torvalds@linux-foundation.org>
:::::: CC: Linus Torvalds <torvalds@linux-foundation.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
next reply other threads:[~2021-12-31 17:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-31 17:08 kernel test robot [this message]
2021-12-31 19:35 ` Al Viro
2022-01-01 13:08 ` Greg Kroah-Hartman
2022-01-01 18:40 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202201010156.bJvO7Gaw-lkp@intel.com \
--to=lkp@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome