mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alberto Merciai <alb3rt0.m3rciai@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: alb3rt0.m3rciai@gmail.com, linuxfancy@googlegroups.com,
	Larry Finger <Larry.Finger@lwfinger.net>,
	Phillip Potter <phil@philpotter.co.uk>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Michael Straube <straube.linux@gmail.com>,
	Martin Kaiser <martin@kaiser.cx>,
	"Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	Saurav Girepunje <saurav.girepunje@gmail.com>,
	Ivan Safonov <insafonov@gmail.com>,
	Yang Li <yang.lee@linux.alibaba.com>,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	Zameer Manji <zmanji@gmail.com>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH 32/56] staging: r8188eu: rename camelcase GetFrameSubType to get_frame_subtype
Date: Mon,  3 Jan 2022 20:02:07 +0100	[thread overview]
Message-ID: <20220103190326.363960-33-alb3rt0.m3rciai@gmail.com> (raw)
In-Reply-To: <20220103190326.363960-1-alb3rt0.m3rciai@gmail.com>

Rename camel case macro GetFrameSubType into get_frame_subtype.

Signed-off-by: Alberto Merciai <alb3rt0.m3rciai@gmail.com>
---
 drivers/staging/r8188eu/core/rtw_mlme_ext.c   |  8 ++++----
 drivers/staging/r8188eu/core/rtw_p2p.c        |  2 +-
 drivers/staging/r8188eu/core/rtw_recv.c       | 18 +++++++++---------
 drivers/staging/r8188eu/core/rtw_security.c   |  4 ++--
 drivers/staging/r8188eu/core/rtw_wlan_util.c  |  2 +-
 drivers/staging/r8188eu/hal/rtl8188e_rxdesc.c |  2 +-
 drivers/staging/r8188eu/include/wifi.h        |  2 +-
 7 files changed, 19 insertions(+), 19 deletions(-)

diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
index 5d0901f72cd8..0e7e7143b5fc 100644
--- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c
+++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
@@ -426,7 +426,7 @@ void mgt_dispatcher(struct adapter *padapter, struct recv_frame *precv_frame)
 
 	ptable = mlme_sta_tbl;
 
-	index = GetFrameSubType(pframe) >> 4;
+	index = get_frame_subtype(pframe) >> 4;
 
 	if (index > 13)
 		return;
@@ -443,7 +443,7 @@ void mgt_dispatcher(struct adapter *padapter, struct recv_frame *precv_frame)
 		psta->RxMgmtFrameSeqNum = precv_frame->attrib.seq_num;
 	}
 
-	switch (GetFrameSubType(pframe)) {
+	switch (get_frame_subtype(pframe)) {
 	case WIFI_AUTH:
 		if (check_fwstate(pmlmepriv, WIFI_AP_STATE))
 			ptable->func = &OnAuth;
@@ -970,7 +970,7 @@ unsigned int OnAssocReq(struct adapter *padapter, struct recv_frame *precv_frame
 	if ((pmlmeinfo->state & 0x03) != WIFI_FW_AP_STATE)
 		return _FAIL;
 
-	frame_type = GetFrameSubType(pframe);
+	frame_type = get_frame_subtype(pframe);
 	if (frame_type == WIFI_ASSOCREQ) {
 		reassoc = 0;
 		ie_offset = _ASOCREQ_IE_OFFSET_;
@@ -6217,7 +6217,7 @@ u8 collect_bss_info(struct adapter *padapter, struct recv_frame *precv_frame, st
 
 	memset(bssid, 0, sizeof(struct wlan_bssid_ex));
 
-	subtype = GetFrameSubType(pframe);
+	subtype = get_frame_subtype(pframe);
 
 	if (subtype == WIFI_BEACON) {
 		bssid->Reserved[0] = 1;
diff --git a/drivers/staging/r8188eu/core/rtw_p2p.c b/drivers/staging/r8188eu/core/rtw_p2p.c
index 7b30b9b64b41..aa739ae86d22 100644
--- a/drivers/staging/r8188eu/core/rtw_p2p.c
+++ b/drivers/staging/r8188eu/core/rtw_p2p.c
@@ -815,7 +815,7 @@ u32 process_assoc_req_p2p_ie(struct wifidirect_info *pwdinfo, u8 *pframe, uint l
 	if (!rtw_p2p_chk_role(pwdinfo, P2P_ROLE_GO))
 		return P2P_STATUS_FAIL_REQUEST_UNABLE;
 
-	frame_type = GetFrameSubType(pframe);
+	frame_type = get_frame_subtype(pframe);
 	if (frame_type == WIFI_ASSOCREQ)
 		ie_offset = _ASOCREQ_IE_OFFSET_;
 	else /*  WIFI_REASSOCREQ */
diff --git a/drivers/staging/r8188eu/core/rtw_recv.c b/drivers/staging/r8188eu/core/rtw_recv.c
index 9902adf99142..8fd2ae89d7eb 100644
--- a/drivers/staging/r8188eu/core/rtw_recv.c
+++ b/drivers/staging/r8188eu/core/rtw_recv.c
@@ -707,10 +707,10 @@ static int ap2sta_data_frame(
 			goto exit;
 		}
 
-		/* if ((GetFrameSubType(ptr) & WIFI_QOS_DATA_TYPE) == WIFI_QOS_DATA_TYPE) { */
+		/* if ((get_frame_subtype(ptr) & WIFI_QOS_DATA_TYPE) == WIFI_QOS_DATA_TYPE) { */
 		/*  */
 
-		if (GetFrameSubType(ptr) & BIT(6)) {
+		if (get_frame_subtype(ptr) & BIT(6)) {
 			/* No data, will not indicate to upper layer, temporily count it here */
 			count_rx_stats(adapter, precv_frame, *psta);
 			ret = RTW_RX_HANDLED;
@@ -784,11 +784,11 @@ static int sta2ap_data_frame(struct adapter *adapter,
 
 		process_pwrbit_data(adapter, precv_frame);
 
-		if ((GetFrameSubType(ptr) & WIFI_QOS_DATA_TYPE) == WIFI_QOS_DATA_TYPE) {
+		if ((get_frame_subtype(ptr) & WIFI_QOS_DATA_TYPE) == WIFI_QOS_DATA_TYPE) {
 			process_wmmps_data(adapter, precv_frame);
 		}
 
-		if (GetFrameSubType(ptr) & BIT(6)) {
+		if (get_frame_subtype(ptr) & BIT(6)) {
 			/* No data, will not indicate to upper layer, temporily count it here */
 			count_rx_stats(adapter, precv_frame, *psta);
 			ret = RTW_RX_HANDLED;
@@ -827,7 +827,7 @@ static int validate_recv_ctrl_frame(struct adapter *padapter,
 		return _FAIL;
 
 	/* only handle ps-poll */
-	if (GetFrameSubType(pframe) == WIFI_PSPOLL) {
+	if (get_frame_subtype(pframe) == WIFI_PSPOLL) {
 		u16 aid;
 		u8 wmmps_ac = 0;
 		struct sta_info *psta = NULL;
@@ -944,11 +944,11 @@ static int validate_recv_mgnt_frame(struct adapter *padapter,
 	psta = rtw_get_stainfo(&padapter->stapriv, GetAddr2Ptr(precv_frame->rx_data));
 	if (psta) {
 		psta->sta_stats.rx_mgnt_pkts++;
-		if (GetFrameSubType(precv_frame->rx_data) == WIFI_BEACON) {
+		if (get_frame_subtype(precv_frame->rx_data) == WIFI_BEACON) {
 			psta->sta_stats.rx_beacon_pkts++;
-		} else if (GetFrameSubType(precv_frame->rx_data) == WIFI_PROBEREQ) {
+		} else if (get_frame_subtype(precv_frame->rx_data) == WIFI_PROBEREQ) {
 			psta->sta_stats.rx_probereq_pkts++;
-		} else if (GetFrameSubType(precv_frame->rx_data) == WIFI_PROBERSP) {
+		} else if (get_frame_subtype(precv_frame->rx_data) == WIFI_PROBERSP) {
 			if (!memcmp(padapter->eeprompriv.mac_addr, GetAddr1Ptr(precv_frame->rx_data), ETH_ALEN))
 				psta->sta_stats.rx_probersp_pkts++;
 			else if (is_broadcast_mac_addr(GetAddr1Ptr(precv_frame->rx_data)) ||
@@ -1101,7 +1101,7 @@ static int validate_recv_frame(struct adapter *adapter, struct recv_frame *precv
 	}
 
 	type =  get_frame_type(ptr);
-	subtype = GetFrameSubType(ptr); /* bit(7)~bit(2) */
+	subtype = get_frame_subtype(ptr); /* bit(7)~bit(2) */
 
 	pattrib->to_fr_ds = get_tofr_ds(ptr);
 
diff --git a/drivers/staging/r8188eu/core/rtw_security.c b/drivers/staging/r8188eu/core/rtw_security.c
index 42ff5fd5ddad..e8d2242b92ea 100644
--- a/drivers/staging/r8188eu/core/rtw_security.c
+++ b/drivers/staging/r8188eu/core/rtw_security.c
@@ -973,7 +973,7 @@ static int aes_cipher(u8 *key, uint hdrlen, u8 *pframe, uint plen)
 	u8 padded_buffer[16];
 	u8 mic[8];
 	uint	frtype  = get_frame_type(pframe);
-	uint	frsubtype  = GetFrameSubType(pframe);
+	uint	frsubtype  = get_frame_subtype(pframe);
 
 	frsubtype = frsubtype >> 4;
 
@@ -1167,7 +1167,7 @@ static int aes_decipher(struct adapter *padapter, u8 *key, uint hdrlen,
 
 /*	uint	offset = 0; */
 	uint	frtype  = get_frame_type(pframe);
-	uint	frsubtype  = GetFrameSubType(pframe);
+	uint	frsubtype  = get_frame_subtype(pframe);
 
 	frsubtype = frsubtype >> 4;
 
diff --git a/drivers/staging/r8188eu/core/rtw_wlan_util.c b/drivers/staging/r8188eu/core/rtw_wlan_util.c
index d40669c21fc1..5f4c9d61511e 100644
--- a/drivers/staging/r8188eu/core/rtw_wlan_util.c
+++ b/drivers/staging/r8188eu/core/rtw_wlan_util.c
@@ -872,7 +872,7 @@ int rtw_check_bcn_info(struct adapter  *Adapter, u8 *pframe, u32 packet_len)
 	if (!bssid)
 		return _FAIL;
 
-	subtype = GetFrameSubType(pframe) >> 4;
+	subtype = get_frame_subtype(pframe) >> 4;
 
 	if (subtype == WIFI_BEACON)
 		bssid->Reserved[0] = 1;
diff --git a/drivers/staging/r8188eu/hal/rtl8188e_rxdesc.c b/drivers/staging/r8188eu/hal/rtl8188e_rxdesc.c
index 90d426199f52..9ffb1af5d846 100644
--- a/drivers/staging/r8188eu/hal/rtl8188e_rxdesc.c
+++ b/drivers/staging/r8188eu/hal/rtl8188e_rxdesc.c
@@ -150,7 +150,7 @@ void update_recvframe_phyinfo_88e(struct recv_frame *precvframe, struct phy_stat
 				  myid(&padapter->eeprompriv), ETH_ALEN));
 
 	pkt_info.bPacketBeacon = pkt_info.bPacketMatchBSSID &&
-				 (GetFrameSubType(wlanhdr) == WIFI_BEACON);
+				 (get_frame_subtype(wlanhdr) == WIFI_BEACON);
 
 	if (pkt_info.bPacketBeacon) {
 		if (check_fwstate(&padapter->mlmepriv, WIFI_STATION_STATE))
diff --git a/drivers/staging/r8188eu/include/wifi.h b/drivers/staging/r8188eu/include/wifi.h
index 7053185667a5..4e000ff8d58a 100644
--- a/drivers/staging/r8188eu/include/wifi.h
+++ b/drivers/staging/r8188eu/include/wifi.h
@@ -207,7 +207,7 @@ enum WIFI_REG_DOMAIN {
 #define get_frame_type(pbuf)				\
 	(le16_to_cpu(*(__le16 *)(pbuf)) & (BIT(3) | BIT(2)))
 
-#define GetFrameSubType(pbuf)	(le16_to_cpu(*(__le16 *)(pbuf)) & (BIT(7) |\
+#define get_frame_subtype(pbuf)	(le16_to_cpu(*(__le16 *)(pbuf)) & (BIT(7) |\
 	 BIT(6) | BIT(5) | BIT(4) | BIT(3) | BIT(2)))
 
 #define SetFrameSubType(pbuf, type) \
-- 
2.25.1


  parent reply	other threads:[~2022-01-03 19:35 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-03 19:01 [PATCH 00/56] staging: r8188eu: wifi.h macros refactoring Alberto Merciai
2022-01-03 19:01 ` [PATCH 01/56] staging: r8188eu: add parenthesis to macro SetToDs Alberto Merciai
2022-01-06 14:12   ` Greg Kroah-Hartman
2022-01-03 19:01 ` [PATCH 02/56] staging: r8188eu: rename camelcase SetToDs to set_to_ds Alberto Merciai
2022-01-06 14:13   ` Greg Kroah-Hartman
2022-01-03 19:01 ` [PATCH 03/56] staging: r8188eu: remove dead macro ClearToDs Alberto Merciai
2022-01-06 14:14   ` Greg Kroah-Hartman
2022-01-08 13:53     ` Alberto Merciai
2022-01-03 19:01 ` [PATCH 04/56] staging: r8188eu: add parenthesis to macro SetFrDs Alberto Merciai
2022-01-03 19:01 ` [PATCH 05/56] staging: r8188eu: rename camelcase SetFrDs to set_fr_ds Alberto Merciai
2022-01-03 19:01 ` [PATCH 06/56] staging: r8188eu: remove dead macro ClearFrDs Alberto Merciai
2022-01-03 19:01 ` [PATCH 07/56] staging: r8188eu: add parenthesis to macro SetMFrag Alberto Merciai
2022-01-03 19:01 ` [PATCH 08/56] staging: r8188eu: rename camelcase SetMFrag to set_m_frag Alberto Merciai
2022-01-03 19:01 ` [PATCH 09/56] staging: r8188eu: rename camelcase GetToDs to get_to_ds Alberto Merciai
2022-01-03 19:01 ` [PATCH 10/56] staging: r8188eu: rename camelcase GetFrDs to get_fr_ds Alberto Merciai
2022-01-03 19:01 ` [PATCH 11/56] staging: r8188eu: rename camelcase GetMFrag to get_m_frag Alberto Merciai
2022-01-03 19:01 ` [PATCH 12/56] staging: r8188eu: rename camelcase ClearMFrag to clear_m_frag Alberto Merciai
2022-01-03 19:01 ` [PATCH 13/56] staging: r8188eu: add parenthesis to macro clear_m_frag Alberto Merciai
2022-01-03 19:01 ` [PATCH 14/56] staging: r8188eu: remove dead macro SetRetry Alberto Merciai
2022-01-03 19:01 ` [PATCH 15/56] staging: r8188eu: rename camelcase GetRetry to get_retry Alberto Merciai
2022-01-03 19:01 ` [PATCH 16/56] staging: r8188eu: remove dead macro ClearRetry Alberto Merciai
2022-01-03 19:01 ` [PATCH 17/56] staging: r8188eu: rename camelcase SetPwrMgt to set_pwr_mgt Alberto Merciai
2022-01-03 19:01 ` [PATCH 18/56] staging: r8188eu: add parenthesis to macro set_pwr_mgt Alberto Merciai
2022-01-03 19:01 ` [PATCH 19/56] staging: r8188eu: rename camelcase GetPwrMgt to get_pwr_mgt Alberto Merciai
2022-01-03 19:01 ` [PATCH 20/56] staging: r8188eu: remove dead macro ClearPwrMgt Alberto Merciai
2022-01-03 19:01 ` [PATCH 21/56] staging: r8188eu: rename camelcase SetMData to set_m_data Alberto Merciai
2022-01-03 19:01 ` [PATCH 22/56] staging: r8188eu: add parenthesis to macro set_m_data Alberto Merciai
2022-01-03 19:01 ` [PATCH 23/56] staging: r8188eu: rename camelcase GetMData to get_m_data Alberto Merciai
2022-01-03 19:01 ` [PATCH 24/56] staging: r8188eu: remove dead macro ClearMData Alberto Merciai
2022-01-03 19:02 ` [PATCH 25/56] staging: r8188eu: rename camelcase SetPrivacy to set_privacy Alberto Merciai
2022-01-03 19:02 ` [PATCH 26/56] staging: r8188eu: add parenthesis to macro set_privacy Alberto Merciai
2022-01-03 19:02 ` [PATCH 27/56] staging: r8188eu: rename camelcase GetPrivacy to get_privacy Alberto Merciai
2022-01-03 19:02 ` [PATCH 28/56] staging: r8188eu: remove dead macro ClearPrivacy Alberto Merciai
2022-01-03 19:02 ` [PATCH 29/56] staging: r8188eu: rename camelcase GetOrder to get_order Alberto Merciai
2022-01-03 19:02 ` [PATCH 30/56] staging: r8188eu: rename camelcase GetFrameType to get_frame_type Alberto Merciai
2022-01-03 19:02 ` [PATCH 31/56] staging: r8188eu: remove dead macro SetFrameType Alberto Merciai
2022-01-03 19:02 ` Alberto Merciai [this message]
2022-01-03 19:02 ` [PATCH 33/56] staging: r8188eu: rename camelcase SetFrameSubType to set_frame_subtype Alberto Merciai
2022-01-03 19:02 ` [PATCH 34/56] staging: r8188eu: rename camelcase GetSequence to get_sequence Alberto Merciai
2022-01-03 19:02 ` [PATCH 35/56] staging: r8188eu: rename camelcase GetFragNum to get_frag_num Alberto Merciai
2022-01-03 19:02 ` [PATCH 36/56] staging: r8188eu: remove dead macro GetTupleCache Alberto Merciai
2022-01-03 19:02 ` [PATCH 37/56] staging: r8188eu: remove dead macro SetFragNum Alberto Merciai
2022-01-03 19:02 ` [PATCH 38/56] staging: r8188eu: rename camelcase SetSeqNum to set_seq_num Alberto Merciai
2022-01-03 19:02 ` [PATCH 39/56] staging: r8188eu: rename camelcase SetDuration to set_duration Alberto Merciai
2022-01-03 19:02 ` [PATCH 40/56] staging: r8188eu: rename camelcase SetPriority to set_priority Alberto Merciai
2022-01-03 19:02 ` [PATCH 41/56] staging: r8188eu: add parenthesis to macro set_duration Alberto Merciai
2022-01-03 19:02 ` [PATCH 42/56] staging: r8188eu: add parenthesis to macro set_priority Alberto Merciai
2022-01-03 19:02 ` [PATCH 43/56] staging: r8188eu: rename camelcase GetPriority to get_priority Alberto Merciai
2022-01-03 19:02 ` [PATCH 44/56] staging: r8188eu: rename camelcase SetEOSP to set_eosp Alberto Merciai
2022-01-03 19:02 ` [PATCH 45/56] staging: r8188eu: add parenthesis to macro set_eosp Alberto Merciai
2022-01-03 19:02 ` [PATCH 46/56] staging: r8188eu: remove dead macro GetTid Alberto Merciai
2022-01-03 19:02 ` [PATCH 47/56] staging: r8188eu: rename camelcase SetAckpolicy to set_ack_policy Alberto Merciai
2022-01-03 19:02 ` [PATCH 48/56] staging: r8188eu: add parenthesis to macro set_ack_policy Alberto Merciai
2022-01-03 19:02 ` [PATCH 49/56] staging: r8188eu: rename camelcase GetAckpolicy into get_ack_policy Alberto Merciai
2022-01-03 19:02 ` [PATCH 50/56] staging: r8188eu: rename camelcase GetAMsdu to get_a_msdu Alberto Merciai
2022-01-03 19:02 ` [PATCH 51/56] staging: r8188eu: remove dead macro SetAMsdu Alberto Merciai
2022-01-03 19:02 ` [PATCH 52/56] staging: r8188eu: rename camelcase GetAid to get_aid Alberto Merciai
2022-01-03 19:02 ` [PATCH 53/56] staging: r8188eu: rename camelcase GetAddr1Ptr to get_addr_1_ptr Alberto Merciai
2022-01-03 19:02 ` [PATCH 54/56] staging: r8188eu: rename camelcase GetAddr2Ptr to get_addr_2_ptr Alberto Merciai
2022-01-03 19:02 ` [PATCH 55/56] staging: r8188eu: rename camelcase GetAddr3Ptr to get_addr_3_ptr Alberto Merciai
2022-01-03 19:02 ` [PATCH 56/56] staging: r8188eu: rename camelcase GetAddr4Ptr to get_addr_4_ptr Alberto Merciai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220103190326.363960-33-alb3rt0.m3rciai@gmail.com \
    --to=alb3rt0.m3rciai@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=dan.carpenter@oracle.com \
    --cc=fmdefrancesco@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=insafonov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=linuxfancy@googlegroups.com \
    --cc=martin@kaiser.cx \
    --cc=phil@philpotter.co.uk \
    --cc=saurav.girepunje@gmail.com \
    --cc=straube.linux@gmail.com \
    --cc=yang.lee@linux.alibaba.com \
    --cc=zmanji@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®