From: "Tomasz Warniełło" <tomasz.warniello@gmail.com>
To: Jonathan Corbet <corbet@lwn.net>
Cc: Jani Nikula <jani.nikula@linux.intel.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scripts: kernel-doc: transform documentation into POD
Date: Tue, 4 Jan 2022 00:56:13 +0100 [thread overview]
Message-ID: <20220104005613.227f0432@fuji.fritz.box> (raw)
In-Reply-To: <8735m4zdlv.fsf@meer.lwn.net>
On Mon, 03 Jan 2022 14:57:48 -0700
Jonathan Corbet <corbet@lwn.net> wrote:
> One thread per version is good; please do not post new versions to old
> threads. A tool like "git send-email" can be your friend here. See
> Documentation/process/submitting-patches.rst for lots of details on how
> to submit patches.
Ok, thanks. I'll try to do it correctly this time...
> Along these lines, I appreciate that you broke up the series as I
> requested, but you overdid it a bit. Think in terms of logical changes
> and making things easy to review, and you should be able to coalesce
> things a bit.
I'm not good at guessing what seems logical to others, especially those I
don't know much. No sarcasm here. Luckily it's not that many of them, so
hopefully they'll pass the exam overdone as they are.
> >> - Stick with current coding conventions
> >
> > To be honest, I need to think this over.
>
> Think hard; if you're unable to work with the kernel project's
> conventions, there's not a lot of point in resubmitting the patches.
Let's finish this one together.
As for the actual code corrections, I see I put 1 tab too many in
two places in the last version. So I guess I just need to reduce them
by 1? No sarcasm again... So let me know before I've sent the next version,
if you please.
Ch, TW
next prev parent reply other threads:[~2022-01-03 23:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 22:55 Tomasz Warniełło
2021-12-16 23:12 ` Jonathan Corbet
2021-12-17 9:43 ` Jani Nikula
2022-01-03 4:18 ` Tomasz Warniełło
2022-01-03 9:04 ` Jani Nikula
2022-01-03 17:30 ` Tomasz Warniełło
2022-01-03 20:04 ` Jonathan Corbet
2022-01-03 21:48 ` Tomasz Warniełło
2022-01-03 21:57 ` Jonathan Corbet
2022-01-03 23:56 ` Tomasz Warniełło [this message]
2022-01-03 20:40 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220104005613.227f0432@fuji.fritz.box \
--to=tomasz.warniello@gmail.com \
--cc=corbet@lwn.net \
--cc=jani.nikula@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome