From: cgel.zte@gmail.com
To: gregkh@linuxfoundation.org
Cc: arnd@arndb.de, cgel.zte@gmail.com, chi.minghao@zte.com.cn,
fkassabri@habana.ai, linux-kernel@vger.kernel.org,
obitton@habana.ai, ogabbay@kernel.org, osharabi@habana.ai,
ynudelman@habana.ai, zealci@zte.com.cn
Subject: Re: [PATCH misc-next] drivers/misc: remove redundant rc variable
Date: Wed, 5 Jan 2022 09:22:29 +0000 [thread overview]
Message-ID: <20220105092229.617027-1-chi.minghao@zte.com.cn> (raw)
In-Reply-To: <YdQzUPW5FI0yIi0P@kroah.com>
I found that there are indeed some optimizations
after removing the redundancy.
For example:
int foo(int a, int b)
{
int ret;
ret = a>b ? a: b;
return ret;
}
int main()
{
int val;
val = foo(7,2);
return 0;
}
and
int foo(int a, int b)
{
return a>b ? a: b;
}
int main()
{
int val;
val = foo(7,2);
return 0;
}
The corresponding disassembly code is as follows:
1129: f3 0f 1e fa endbr64
112d: 55 push %rbp
112e: 48 89 e5 mov %rsp,%rbp
1131: 89 7d fc mov %edi,-0x4(%rbp)
1134: 89 75 f8 mov %esi,-0x8(%rbp)
1137: 8b 45 fc mov -0x4(%rbp),%eax
113a: 39 45 f8 cmp %eax,-0x8(%rbp)
113d: 0f 4d 45 f8 cmovge -0x8(%rbp),%eax
1141: 5d pop %rbp
1142: c3 retq
and
1129: f3 0f 1e fa endbr64
112d: 55 push %rbp
112e: 48 89 e5 mov %rsp,%rbp
1131: 89 7d ec mov %edi,-0x14(%rbp)
1134: 89 75 e8 mov %esi,-0x18(%rbp)
1137: 8b 45 ec mov -0x14(%rbp),%eax
113a: 39 45 e8 cmp %eax,-0x18(%rbp)
113d: 0f 4d 45 e8 cmovge -0x18(%rbp),%eax
1141: 89 45 fc mov %eax,-0x4(%rbp)
1144: 8b 45 fc mov -0x4(%rbp),%eax
1147: 5d pop %rbp
1148: c3 retq
After removing the redundancy, the compiler does
have some optimizations
next prev parent reply other threads:[~2022-01-05 9:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-04 11:34 cgel.zte
2022-01-04 11:45 ` Greg KH
2022-01-05 9:22 ` cgel.zte [this message]
2022-01-05 10:08 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2021-12-15 6:04 cgel.zte
2021-12-15 8:52 ` Andrew Donnellan
2021-12-26 21:52 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220105092229.617027-1-chi.minghao@zte.com.cn \
--to=cgel.zte@gmail.com \
--cc=arnd@arndb.de \
--cc=chi.minghao@zte.com.cn \
--cc=fkassabri@habana.ai \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=obitton@habana.ai \
--cc=ogabbay@kernel.org \
--cc=osharabi@habana.ai \
--cc=ynudelman@habana.ai \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®