mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: xkernel.wang@foxmail.com
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org,
	Masami Hiramatsu <mhiramat@kernel.org>
Subject: Re: [PATCH] tracing: check the return value of kstrndup()
Date: Wed, 5 Jan 2022 17:11:12 -0500	[thread overview]
Message-ID: <20220105171112.337844b9@gandalf.local.home> (raw)
In-Reply-To: <tencent_4D6E270731456EB88712ED7F13883C334906@qq.com>

Masami, can you ack this?

-- Steve


On Tue, 14 Dec 2021 10:26:46 +0800
xkernel.wang@foxmail.com wrote:

> From: Xiaoke Wang <xkernel.wang@foxmail.com>
> 
> kstrndup() is a memory allocation-related function, it returns NULL when
> some internal memory errors happen. It is better to check the return
> value of it so to catch the memory error in time.
> 
> Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>
> ---
>  kernel/trace/trace_probe.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c
> index 3ed2a3f..bb4605b 100644
> --- a/kernel/trace/trace_probe.c
> +++ b/kernel/trace/trace_probe.c
> @@ -356,6 +356,8 @@ static int __parse_imm_string(char *str, char **pbuf, int offs)
>  		return -EINVAL;
>  	}
>  	*pbuf = kstrndup(str, len - 1, GFP_KERNEL);
> +	if (!*pbuf)
> +		return -ENOMEM;
>  	return 0;
>  }
>  


  reply	other threads:[~2022-01-05 22:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-14  2:26 xkernel.wang
2022-01-05 22:11 ` Steven Rostedt [this message]
2022-01-05 22:40   ` Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220105171112.337844b9@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=mingo@redhat.com \
    --cc=xkernel.wang@foxmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®