From: Steven Rostedt <rostedt@goodmis.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Xiangyang Zhang <xyz.sun.ok@gmail.com>,
mingo@redhat.com, oleg@redhat.com, namhyung.kim@lge.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tracing/kprobes: 'nmissed' not showed correctly for kretprobe
Date: Wed, 5 Jan 2022 18:10:29 -0500 [thread overview]
Message-ID: <20220105181029.4fa08f6a@gandalf.local.home> (raw)
In-Reply-To: <20220106073203.123c4f7e38cc07eccd02aa9b@kernel.org>
On Thu, 6 Jan 2022 07:32:03 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:
> OK, this is a good catch :), but there are 2 issues.
>
> 1. kretprobe can be skipped by 2 reasons, shortage of kretprobe_instance which
> is counted by rp.nmissed, and kprobe itself is missed by some reason (this
> can be happen if KPROBE_EVENTS_ON_NOTRACE=n. Thus, better solution is to show
> 'tk->rp.nmissed + tk->rp.kp.nmissed'.
>
> 2. the commit c31ffb3ff633 is not actual commit which introduce this issue.
> this was introduced by 4a846b443b4e ("tracing/kprobes: Cleanup kprobe tracer code.")
>
> 'git blame' tells you the commit which changes that line, but that can be just
> a refactoring (renaming). I recommend you to search the correct one by 'git log -p'.
Masami, thanks for the review.
Xiangyang, can you please send a v2 with Masami's suggestions?
-- Steve
next prev parent reply other threads:[~2022-01-05 23:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-11 15:00 Xiangyang Zhang
2022-01-05 19:15 ` Steven Rostedt
2022-01-05 19:22 ` Steven Rostedt
2022-01-05 22:32 ` Masami Hiramatsu
2022-01-05 23:10 ` Steven Rostedt [this message]
2022-01-06 2:14 ` xy zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220105181029.4fa08f6a@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung.kim@lge.com \
--cc=oleg@redhat.com \
--cc=xyz.sun.ok@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®