From: Stephen Boyd <sboyd@kernel.org>
To: Colin Ian King <colin.i.king@gmail.com>,
Dinh Nguyen <dinguyen@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
linux-clk@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, llvm@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: socfpga: remove redundant assignment after a mask operation
Date: Wed, 05 Jan 2022 16:33:17 -0800 [thread overview]
Message-ID: <20220106003318.E28E7C36AE9@smtp.kernel.org> (raw)
In-Reply-To: <20211230150321.167576-1-colin.i.king@gmail.com>
Quoting Colin Ian King (2021-12-30 07:03:21)
> The assignment operation after a & mask operation is redundant, the
> variables being assigned are not used afterwards. Replace the &=
> operator with just & operator.
>
> Cleans up two clang-scan warnings:
> drivers/clk/socfpga/clk-gate.c:37:10: warning: Although the value stored
> to 'l4_src' is used in the enclosing expression, the value is never
> actually read from 'l4_src' [deadcode.DeadStores]
> return l4_src &= 0x1;
> ^ ~~~
> drivers/clk/socfpga/clk-gate.c:46:10: warning: Although the value stored
> to 'perpll_src' is used in the enclosing expression, the value is never
> actually read from 'perpll_src' [deadcode.DeadStores]
> return perpll_src &= 0x3;
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
Applied to clk-next
prev parent reply other threads:[~2022-01-06 0:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-30 15:03 Colin Ian King
2021-12-30 18:10 ` Dinh Nguyen
2022-01-06 0:33 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220106003318.E28E7C36AE9@smtp.kernel.org \
--to=sboyd@kernel.org \
--cc=colin.i.king@gmail.com \
--cc=dinguyen@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mturquette@baylibre.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome