From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc: linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Wolfgang Grandegger <wg@grandegger.com>,
linux-can@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [RFC PATCH] can: flexcan: add ethtool support to get rx/tx ring parameters
Date: Sun, 9 Jan 2022 12:37:16 +0100 [thread overview]
Message-ID: <20220109113716.r4l432ixsjbbcwtu@pengutronix.de> (raw)
In-Reply-To: <CABGWkvoGs_VBGD-7dt18LY9NV=63w50OceKjmaKYeqDe_WJk9g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 961 bytes --]
On 09.01.2022 12:22:54, Dario Binacchi wrote:
> > > static const struct ethtool_ops flexcan_ethtool_ops = {
> > > + .get_ringparam = flexcan_get_ringparam,
> > > .get_sset_count = flexcan_get_sset_count,
> > > .get_strings = flexcan_get_strings,
> > > .get_priv_flags = flexcan_get_priv_flags,
> >
> > BTW: If you're looking for more TX performance, this can be done by
> > using more than one TX buffer.
>
> I didn't expect only one message buffer to be used for transmission
It was easier to implement, but now we've sorted it out how to implement
multiple TX buffers race free and lock-less. Have a look at the
mcp251xfd driver.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2022-01-09 11:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-08 18:16 Dario Binacchi
2022-01-08 20:16 ` Marc Kleine-Budde
2022-01-09 11:22 ` Dario Binacchi
2022-01-09 11:37 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220109113716.r4l432ixsjbbcwtu@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=dario.binacchi@amarulasolutions.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®