From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C21BFC433F5 for ; Wed, 12 Jan 2022 14:03:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353900AbiALODN (ORCPT ); Wed, 12 Jan 2022 09:03:13 -0500 Received: from verein.lst.de ([213.95.11.211]:46247 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242083AbiALODI (ORCPT ); Wed, 12 Jan 2022 09:03:08 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id 6626768AFE; Wed, 12 Jan 2022 15:03:04 +0100 (CET) Date: Wed, 12 Jan 2022 15:03:04 +0100 From: Christoph Hellwig To: Kai-Heng Feng Cc: Christoph Hellwig , kbusch@kernel.org, axboe@fb.com, sagi@grimberg.me, Rajat Jain , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nvme: Mark external NVMe devices as removable Message-ID: <20220112140304.GA27446@lst.de> References: <20220112013154.1210480-1-kai.heng.feng@canonical.com> <20220112071659.GA4502@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 12, 2022 at 08:50:33PM +0800, Kai-Heng Feng wrote: > USB thumb drives also use this flag, so I am not sure why it's not > applicable to NVMe? They shouldn't report this flag and might need fixing.