From: Jakub Kicinski <kuba@kernel.org>
To: cgel.zte@gmail.com, Minghao Chi <chi.minghao@zte.com.cn>
Cc: Richard Cochran <richardcochran@gmail.com>,
andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] drivers/net/phy/dp83640: remove unneeded val variable
Date: Tue, 18 Jan 2022 09:15:51 -0800 [thread overview]
Message-ID: <20220118091551.7aa44124@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> (raw)
In-Reply-To: <20220118151904.GA31192@hoboy.vegasvil.org>
On Tue, 18 Jan 2022 07:19:04 -0800 Richard Cochran wrote:
> On Tue, Jan 18, 2022 at 07:54:38AM +0000, cgel.zte@gmail.com wrote:
> > From: Minghao Chi <chi.minghao@zte.com.cn>
> >
> > Return value from phy_read() directly instead
> > of taking this in another redundant variable.
>
> NAK this is purely cosmetic and not clearly better WRT CodingStyle.
>
> > Reported-by: Zeal Robot <zealci@zte.com.cn>
>
> Please make your robot less zealous or filter its results before
> posting.
Plus what does it mean that the bot has signed this off?
> > Signed-off-by: CGEL ZTE <cgel.zte@gmail.com>
> This is the second time I told you. It isn't wise to ignore feedback,
> and it is also rude.
Same, you don't reply to emails and keep making the same mistakes.
I asked you to realign the continuation lines in:
https://lore.kernel.org/all/20220112083942.391fd0d7@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net/
And without replying you just posted:
https://lore.kernel.org/all/20220118075159.925542-1-chi.minghao@zte.com.cn/
prev parent reply other threads:[~2022-01-18 17:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 7:54 cgel.zte
2022-01-18 15:19 ` Richard Cochran
2022-01-18 17:15 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220118091551.7aa44124@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=cgel.zte@gmail.com \
--cc=chi.minghao@zte.com.cn \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®