From: Jakub Kicinski <kuba@kernel.org>
To: cgel.zte@gmail.com
Cc: chi.minghao@zte.com.cn, davem@davemloft.net, dsahern@gmail.com,
dsahern@kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, yoshfuji@linux-ipv6.org,
zealci@zte.com.cn
Subject: Re: [PATCH] net/ipv6: remove redundant err variable
Date: Wed, 19 Jan 2022 07:59:27 -0800 [thread overview]
Message-ID: <20220119075927.0d2c4a21@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> (raw)
In-Reply-To: <20220119055557.931265-1-chi.minghao@zte.com.cn>
On Wed, 19 Jan 2022 05:55:57 +0000 cgel.zte@gmail.com wrote:
> There are more than 3,000 numbers retrieved by the rules I wrote.
> Of course, many of these 3,000 are false positives, and maybe
> there are 300 patches.I wrote this rule similar to returnvar.cocci.
Can you start by improving returnvar.cocci so it catches all the cases?
Then make sure your patches build and don't introduce formatting
problems. Then post them.
prev parent reply other threads:[~2022-01-19 15:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-12 8:26 cgel.zte
2022-01-12 15:54 ` David Ahern
2022-01-12 16:39 ` Jakub Kicinski
2022-01-19 3:00 ` cgel.zte
2022-01-19 3:28 ` Jakub Kicinski
2022-01-19 5:55 ` cgel.zte
2022-01-19 15:59 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220119075927.0d2c4a21@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net \
--to=kuba@kernel.org \
--cc=cgel.zte@gmail.com \
--cc=chi.minghao@zte.com.cn \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=dsahern@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®