From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29053C433F5 for ; Sun, 23 Jan 2022 00:15:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236039AbiAWAPh (ORCPT ); Sat, 22 Jan 2022 19:15:37 -0500 Received: from sin.source.kernel.org ([145.40.73.55]:46744 "EHLO sin.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231836AbiAWAOW (ORCPT ); Sat, 22 Jan 2022 19:14:22 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 1621CCE0920; Sun, 23 Jan 2022 00:14:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D27F1C36AE3; Sun, 23 Jan 2022 00:14:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1642896859; bh=OksXVQlW/gPJ9LytV3kqPMDJ6mNVmLh35P/E7cdZ5+s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HavGGbOHXRRFsPjNnIcRSeA3zL8dBjBbZPnynUXu0VOKzZ9Oym4uBXWAnI9ZY1frN BXZD+W8U5tjN4bXamvb6eVIDVxZDtBu2bEW7Ef/CWN+N4ZkAGjk3pYhDLQPGV7fsuH 8anQh+/DVXiy7iTe2zEBuazYPmexAyTFU+sd0z4VozXCNsz11xKE8i5Lk2amWtqqAp fPDQDpB8Guhzv9/dtf62/Cjk2AfZlG70pmFgyoJRnL3nXfNDmNI0WxWwZor6cZ8Yb7 mO1vRKv0Bt/ziAIsqT7/ThFL0GthMA9zGdfHPBiAJzQbaLlWmemV6/PVmmc7CXXytv zFSZAb0azr9Qg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?=E7=8E=8B=E8=B4=87?= , "Michael S . Tsirkin" , Sasha Levin , jasowang@redhat.com, virtualization@lists.linux-foundation.org Subject: [PATCH AUTOSEL 4.14 3/4] virtio-pci: fix the confusing error message Date: Sat, 22 Jan 2022 19:14:09 -0500 Message-Id: <20220123001412.2460945-3-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220123001412.2460945-1-sashal@kernel.org> References: <20220123001412.2460945-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: 王贇 [ Upstream commit 6017599bb25c20b7a68cbb8e7d534bdc1c36b5e4 ] The error message on the failure of pfn check should tell virtio-pci rather than virtio-mmio, just fix it. Signed-off-by: Michael Wang Suggested-by: Michael S. Tsirkin Link: https://lore.kernel.org/r/ae5e154e-ac59-f0fa-a7c7-091a2201f581@linux.alibaba.com Signed-off-by: Michael S. Tsirkin Signed-off-by: Sasha Levin --- drivers/virtio/virtio_pci_legacy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_pci_legacy.c b/drivers/virtio/virtio_pci_legacy.c index de062fb201bc2..61add42862017 100644 --- a/drivers/virtio/virtio_pci_legacy.c +++ b/drivers/virtio/virtio_pci_legacy.c @@ -145,7 +145,7 @@ static struct virtqueue *setup_vq(struct virtio_pci_device *vp_dev, q_pfn = virtqueue_get_desc_addr(vq) >> VIRTIO_PCI_QUEUE_ADDR_SHIFT; if (q_pfn >> 32) { dev_err(&vp_dev->pci_dev->dev, - "platform bug: legacy virtio-mmio must not be used with RAM above 0x%llxGB\n", + "platform bug: legacy virtio-pci must not be used with RAM above 0x%llxGB\n", 0x1ULL << (32 + PAGE_SHIFT - 30)); err = -E2BIG; goto out_del_vq; -- 2.34.1