From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>,
linux-kernel@vger.kernel.org
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
Michael Trimarchi <michael@amarulasolutions.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Boris Brezillon <bbrezillon@kernel.org>, Han Xu <han.xu@nxp.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH 2/4] mtd: rawnand: gpmi: fix controller timings setting
Date: Sun, 23 Jan 2022 16:23:06 +0100 [thread overview]
Message-ID: <20220123152306.529424-1-miquel.raynal@bootlin.com> (raw)
In-Reply-To: <20220118095434.35081-3-dario.binacchi@amarulasolutions.com>
On Tue, 2022-01-18 at 09:54:32 UTC, Dario Binacchi wrote:
> Set the controller registers according to the real clock rate. The
> controller registers configuration (setup, hold, timeout, ... cycles)
> depends on the clock rate of the GPMI. Using the real rate instead of
> the ideal one, avoids that this inaccuracy (required_rate - real_rate)
> affects the registers setting.
>
> This patch has been tested on two custom boards with i.MX28 and i.MX6
> SOCs:
> - i.MX28:
> required rate 100MHz, real rate 99.3MHz
> - i.MX6
> required rate 100MHz, real rate 99MHz
>
> Fixes: b1206122069a ("mtd: rawnand: gpmi: use core timings instead of an empirical derivation")
> Co-developed-by: Michael Trimarchi <michael@amarulasolutions.com>
> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> Tested-by: Sascha Hauer <s.hauer@pengutronix.de>
> Reviewed-by: Sascha Hauer <s.hauer@pengutronix.de>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.
Miquel
next prev parent reply other threads:[~2022-01-23 15:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 9:54 [PATCH 0/4] Fix and improve gpmi nand on mx28 Dario Binacchi
2022-01-18 9:54 ` [PATCH 1/4] ARM: dts: imx28: reparent gpmi clock to ref_gpmi Dario Binacchi
2022-01-18 9:54 ` [PATCH 2/4] mtd: rawnand: gpmi: fix controller timings setting Dario Binacchi
2022-01-23 15:23 ` Miquel Raynal [this message]
2022-01-18 9:54 ` [PATCH 3/4] mtd: rawnand: gpmi: validate controller clock rate Dario Binacchi
2022-01-23 15:39 ` Miquel Raynal
2022-01-18 9:54 ` [PATCH 4/4] mtd: rawnand: gpmi: support fast edo timings for mx28 Dario Binacchi
2022-01-23 15:39 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220123152306.529424-1-miquel.raynal@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=bbrezillon@kernel.org \
--cc=dario.binacchi@amarulasolutions.com \
--cc=han.xu@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@amarulasolutions.com \
--cc=richard@nod.at \
--cc=s.hauer@pengutronix.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®