From: ira.weiny@intel.com
To: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Patrik Jakobsson <patrik.r.jakobsson@gmail.com>,
Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>
Cc: Ira Weiny <ira.weiny@intel.com>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org,
linux-arm-msm@vger.kernel.org
Subject: [PATCH V2 0/7] DRM kmap() fixes and kmap_local_page() conversions
Date: Sun, 23 Jan 2022 17:54:02 -0800 [thread overview]
Message-ID: <20220124015409.807587-1-ira.weiny@intel.com> (raw)
From: Ira Weiny <ira.weiny@intel.com>
Changes from V1:
Use memcpy_to_page() where appropriate
Rebased to latest
The kmap() call may cause issues with work being done with persistent memory.
For this and other reasons it is being deprecated.
This series starts by converting the last easy kmap() uses in the drm tree to
kmap_local_page().
The final 2 patches fix bugs found while working on the ttm_bo_kmap_ttm()
conversion. They are valid fixes but were found via code inspection not
because of any actual bug so don't require a stable tag.[1]
There is one more call to kmap() used in ttm_bo_kmap_ttm(). Unfortunately,
fixing this is not straight forward so it is left to future work.[2]
[1] https://lore.kernel.org/lkml/fb71af05-a889-8f6e-031b-426b58a64f00@amd.com/
[2] https://lore.kernel.org/lkml/20211215210949.GW3538886@iweiny-DESK2.sc.intel.com/
Ira Weiny (7):
drm/i915: Replace kmap() with kmap_local_page()
drm/amd: Replace kmap() with kmap_local_page()
drm/gma: Remove calls to kmap()
drm/radeon: Replace kmap() with kmap_local_page()
drm/msm: Alter comment to use kmap_local_page()
drm/amdgpu: Ensure kunmap is called on error
drm/radeon: Ensure kunmap is called on error
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 8 ++++----
drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 1 +
drivers/gpu/drm/gma500/gma_display.c | 6 ++----
drivers/gpu/drm/gma500/mmu.c | 8 ++++----
drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 6 ++----
drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 8 ++++----
drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 4 ++--
drivers/gpu/drm/i915/gt/shmem_utils.c | 7 ++-----
drivers/gpu/drm/i915/i915_gem.c | 8 ++++----
drivers/gpu/drm/i915/i915_gpu_error.c | 4 ++--
drivers/gpu/drm/msm/msm_gem_submit.c | 4 ++--
drivers/gpu/drm/radeon/radeon_ttm.c | 4 ++--
drivers/gpu/drm/radeon/radeon_uvd.c | 1 +
13 files changed, 32 insertions(+), 37 deletions(-)
--
2.31.1
next reply other threads:[~2022-01-24 1:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 1:54 ira.weiny [this message]
2022-01-24 1:54 ` [PATCH V2 1/7] drm/i915: Replace kmap() with kmap_local_page() ira.weiny
2022-01-24 1:54 ` [PATCH V2 2/7] drm/amd: " ira.weiny
2022-01-24 1:54 ` [PATCH V2 3/7] drm/gma: Remove calls to kmap() ira.weiny
2022-01-24 16:03 ` Daniel Vetter
2022-01-24 1:54 ` [PATCH V2 4/7] drm/radeon: Replace kmap() with kmap_local_page() ira.weiny
2022-01-24 1:54 ` [PATCH V2 5/7] drm/msm: Alter comment to use kmap_local_page() ira.weiny
2022-01-24 1:54 ` [PATCH V2 6/7] drm/amdgpu: Ensure kunmap is called on error ira.weiny
2022-01-24 1:54 ` [PATCH V2 7/7] drm/radeon: " ira.weiny
2022-01-24 12:08 ` [PATCH V2 0/7] DRM kmap() fixes and kmap_local_page() conversions Christian König
2022-01-24 18:27 ` Ira Weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220124015409.807587-1-ira.weiny@intel.com \
--to=ira.weiny@intel.com \
--cc=airlied@linux.ie \
--cc=amd-gfx@lists.freedesktop.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrik.r.jakobsson@gmail.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome