From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A733C3526E for ; Mon, 24 Jan 2022 23:07:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1843468AbiAXXEC (ORCPT ); Mon, 24 Jan 2022 18:04:02 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:46606 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1578129AbiAXWBp (ORCPT ); Mon, 24 Jan 2022 17:01:45 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: detlev) with ESMTPSA id 2623B1F438F5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1643061704; bh=uSJHLoKhBOSZViMqnrdcTgo72DKBbNURHymWklur8XE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=a2yCkKBHr2uUjSxIMcYN3dmciK6j6fWs///x9K1LcFfD814QT9O0L+p8ARn6+V+z2 n13j7E9skyrNQh6nr8JVnoPjEIZLk6kx8GsfIf8yJyWnkmnX87IKDHVYd0iuIfpSDy JCLlYsZNM/AtjdeNd8aKLoqVTVCJO1jhhpGavRKEhYE/Z97xy3IpfDanNBolcZgGBH 22VP5z7PslPyWbqUHl+hTlpMsq+XLePs7Trfr+MIy8GiW9lsyBJHNwfcrMB3g3jDq7 7zQszH3Hc8tk52wlUIg+yOyZofcxlUzFDZw3H0vqqlU7+Cwqktp53GG17PuyzY7l7U kEXw5y0r9zLSA== From: Detlev Casanova To: linux-kernel@vger.kernel.org Cc: Dave Stevenson , Liam Girdwood , Mark Brown , Detlev Casanova Subject: [PATCH v3 7/9] regulator: rpi-panel: Remove get_brightness hook Date: Mon, 24 Jan 2022 17:01:27 -0500 Message-Id: <20220124220129.158891-8-detlev.casanova@collabora.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220124220129.158891-1-detlev.casanova@collabora.com> References: <20220124220129.158891-1-detlev.casanova@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dave Stevenson The driver was implementing a get_brightness function that tried to read back the PWM setting of the display to report as the current brightness. The controller on the display does not support that, therefore we end up reporting a brightness of 0, and that confuses systemd's backlight service. Remove the hook so that the framework returns the current brightness automatically. Signed-off-by: Dave Stevenson Signed-off-by: Detlev Casanova --- .../regulator/rpi-panel-attiny-regulator.c | 23 ------------------- 1 file changed, 23 deletions(-) diff --git a/drivers/regulator/rpi-panel-attiny-regulator.c b/drivers/regulator/rpi-panel-attiny-regulator.c index 998233f14085..8090b9a485b5 100644 --- a/drivers/regulator/rpi-panel-attiny-regulator.c +++ b/drivers/regulator/rpi-panel-attiny-regulator.c @@ -207,31 +207,8 @@ static int attiny_update_status(struct backlight_device *bl) return ret; } -static int attiny_get_brightness(struct backlight_device *bl) -{ - struct attiny_lcd *state = bl_get_data(bl); - struct regmap *regmap = state->regmap; - int ret, brightness, i; - - mutex_lock(&state->lock); - - for (i = 0; i < 10; i++) { - ret = regmap_read(regmap, REG_PWM, &brightness); - if (!ret) - break; - } - - mutex_unlock(&state->lock); - - if (ret) - return ret; - - return brightness; -} - static const struct backlight_ops attiny_bl = { .update_status = attiny_update_status, - .get_brightness = attiny_get_brightness, }; static int attiny_gpio_get_direction(struct gpio_chip *gc, unsigned int off) -- 2.34.1