mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Detlev Casanova <detlev.casanova@collabora.com>
To: linux-kernel@vger.kernel.org
Cc: Dave Stevenson <dave.stevenson@raspberrypi.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Detlev Casanova <detlev.casanova@collabora.com>
Subject: [PATCH v3 8/9] regulator/rpi-panel-attiny: Use the regmap cache
Date: Mon, 24 Jan 2022 17:01:28 -0500	[thread overview]
Message-ID: <20220124220129.158891-9-detlev.casanova@collabora.com> (raw)
In-Reply-To: <20220124220129.158891-1-detlev.casanova@collabora.com>

From: Dave Stevenson <dave.stevenson@raspberrypi.com>

The I2C to the Atmel is very fussy, and locks up easily on
Pi0-3 particularly on reads.

The LCD power status is controlled solely by this driver, so
rather than reading it back from the Atmel, use the regmap cache
to avoid reading values.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>
---
 drivers/regulator/rpi-panel-attiny-regulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/rpi-panel-attiny-regulator.c b/drivers/regulator/rpi-panel-attiny-regulator.c
index 8090b9a485b5..6e408a4b2c21 100644
--- a/drivers/regulator/rpi-panel-attiny-regulator.c
+++ b/drivers/regulator/rpi-panel-attiny-regulator.c
@@ -76,7 +76,7 @@ static const struct regmap_config attiny_regmap_config = {
 	.val_bits = 8,
 	.disable_locking = 1,
 	.max_register = REG_WRITE_DATA_L,
-	.cache_type = REGCACHE_NONE,
+	.cache_type = REGCACHE_RBTREE,
 };
 
 static int attiny_set_port_state(struct attiny_lcd *state, int reg, u8 val)
-- 
2.34.1


  parent reply	other threads:[~2022-01-24 23:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-24 22:01 [PATCH v3 0/9] regulator: rpi-panel: Support official Raspberry Pi 7 inches touchscreen Detlev Casanova
2022-01-24 22:01 ` [PATCH v3 1/9] regulator: rpi-panel: Register with a unique backlight name Detlev Casanova
2022-01-24 22:01 ` [PATCH v3 2/9] regulator: rpi-panel: Handle I2C errors/timing to the Atmel Detlev Casanova
2022-01-24 22:01 ` [PATCH v3 3/9] regulator: rpi-panel: Serialise operations Detlev Casanova
2022-01-24 22:01 ` [PATCH v3 4/9] regulator: rpi-panel: Ensure the backlight is off during probe Detlev Casanova
2022-01-24 22:01 ` [PATCH v3 5/9] regulator: rpi-panel: Convert to drive lines directly Detlev Casanova
2022-01-24 22:01 ` [PATCH v3 6/9] regulator: rpi-panel: Add GPIO control for panel and touch resets Detlev Casanova
2022-01-24 22:01 ` [PATCH v3 7/9] regulator: rpi-panel: Remove get_brightness hook Detlev Casanova
2022-01-24 22:01 ` Detlev Casanova [this message]
2022-01-24 22:01 ` [PATCH v3 9/9] regulator/rpi-panel-attiny: Use two transactions for I2C read Detlev Casanova
2022-01-28 23:47 ` [PATCH v3 0/9] regulator: rpi-panel: Support official Raspberry Pi 7 inches touchscreen Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220124220129.158891-9-detlev.casanova@collabora.com \
    --to=detlev.casanova@collabora.com \
    --cc=broonie@kernel.org \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®