From: Li Zhijian <lizhijian@cn.fujitsu.com>
To: <linux-rdma@vger.kernel.org>, <zyjzyj2000@gmail.com>,
<jgg@ziepe.ca>, <aharonl@nvidia.com>, <leon@kernel.org>,
<tom@talpey.com>, <tomasz.gromadzki@intel.com>
Cc: <linux-kernel@vger.kernel.org>, <mbloch@nvidia.com>,
<liangwenpeng@huawei.com>, <yangx.jy@fujitsu.com>,
<y-goto@fujitsu.com>, <rpearsonhpe@gmail.com>,
<dan.j.williams@intel.com>, Li Zhijian <lizhijian@cn.fujitsu.com>
Subject: [RFC PATCH v2 1/9] RDMA: mr: Introduce is_pmem
Date: Tue, 25 Jan 2022 16:50:33 +0800 [thread overview]
Message-ID: <20220125085041.49175-2-lizhijian@cn.fujitsu.com> (raw)
In-Reply-To: <20220125085041.49175-1-lizhijian@cn.fujitsu.com>
We can use it to indicate whether the registering mr is associated with
a pmem/nvdimm or not.
Currently, we only update it in rxe driver, for other device/drivers,
they should implement it if needed.
CC: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
---
V2: check 1st byte to avoid crossing page boundary
new scheme to check is_pmem # Dan
---
drivers/infiniband/sw/rxe/rxe_mr.c | 25 +++++++++++++++++++++++++
include/rdma/ib_verbs.h | 1 +
2 files changed, 26 insertions(+)
diff --git a/drivers/infiniband/sw/rxe/rxe_mr.c b/drivers/infiniband/sw/rxe/rxe_mr.c
index 453ef3c9d535..0427baea8c06 100644
--- a/drivers/infiniband/sw/rxe/rxe_mr.c
+++ b/drivers/infiniband/sw/rxe/rxe_mr.c
@@ -161,6 +161,28 @@ void rxe_mr_init_dma(struct rxe_pd *pd, int access, struct rxe_mr *mr)
mr->type = IB_MR_TYPE_DMA;
}
+static bool iova_in_pmem(struct rxe_mr *mr, u64 iova, int length)
+{
+ char *vaddr;
+ int is_pmem;
+
+ /* XXX: Shall me allow length == 0 */
+ if (length == 0) {
+ return false;
+ }
+ /* check the 1st byte only to avoid crossing page boundary */
+ vaddr = iova_to_vaddr(mr, iova, 1);
+ if (!vaddr) {
+ pr_warn("not a valid iova 0x%llx\n", iova);
+ return false;
+ }
+
+ is_pmem = region_intersects(virt_to_phys(vaddr), 1, IORESOURCE_MEM,
+ IORES_DESC_PERSISTENT_MEMORY);
+
+ return is_pmem == REGION_INTERSECTS;
+}
+
int rxe_mr_init_user(struct rxe_pd *pd, u64 start, u64 length, u64 iova,
int access, struct rxe_mr *mr)
{
@@ -235,6 +257,9 @@ int rxe_mr_init_user(struct rxe_pd *pd, u64 start, u64 length, u64 iova,
set->va = start;
set->offset = ib_umem_offset(umem);
+ // iova_in_pmem() must be called after set is updated
+ mr->ibmr.is_pmem = iova_in_pmem(mr, iova, length);
+
return 0;
err_release_umem:
diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h
index 69d883f7fb41..4fa07b123c8d 100644
--- a/include/rdma/ib_verbs.h
+++ b/include/rdma/ib_verbs.h
@@ -1807,6 +1807,7 @@ struct ib_mr {
unsigned int page_size;
enum ib_mr_type type;
bool need_inval;
+ bool is_pmem;
union {
struct ib_uobject *uobject; /* user */
struct list_head qp_entry; /* FR */
--
2.31.1
next prev parent reply other threads:[~2022-01-25 8:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 8:50 [RFC PATCH v2 0/9] RDMA/rxe: Add RDMA FLUSH operation Li Zhijian
2022-01-25 8:50 ` Li Zhijian [this message]
2022-01-25 8:50 ` [RFC PATCH v2 2/9] RDMA: Allow registering MR with flush access flags Li Zhijian
2022-01-25 8:50 ` [RFC PATCH v2 3/9] RDMA/rxe: Allow registering persistent flag for pmem MR only Li Zhijian
2022-01-25 8:50 ` [RFC PATCH v2 4/9] RDMA/rxe: Implement RC RDMA FLUSH service in requester side Li Zhijian
2022-01-25 8:50 ` [RFC PATCH v2 5/9] RDMA/rxe: Set BTH's SE to zero for FLUSH packet Li Zhijian
2022-01-25 8:50 ` [RFC PATCH v2 6/9] RDMA/rxe: Implement flush execution in responder side Li Zhijian
2022-01-25 8:50 ` [RFC PATCH v2 7/9] RDMA/rxe: Implement flush completion Li Zhijian
2022-01-25 8:50 ` [RFC PATCH v2 8/9] RDMA/rxe: Enable RDMA FLUSH capability for rxe device Li Zhijian
2022-01-25 8:50 ` [RFC PATCH v2 9/9] RDMA/rxe: Add RD FLUSH service support Li Zhijian
2022-01-25 8:57 ` [RFC PATCH v2 0/9] RDMA/rxe: Add RDMA FLUSH operation Zhu Yanjun
2022-01-25 10:32 ` lizhijian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220125085041.49175-2-lizhijian@cn.fujitsu.com \
--to=lizhijian@cn.fujitsu.com \
--cc=aharonl@nvidia.com \
--cc=dan.j.williams@intel.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=liangwenpeng@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=rpearsonhpe@gmail.com \
--cc=tom@talpey.com \
--cc=tomasz.gromadzki@intel.com \
--cc=y-goto@fujitsu.com \
--cc=yangx.jy@fujitsu.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®