From: Jakub Kicinski <kuba@kernel.org>
To: menglong8.dong@gmail.com
Cc: nhorman@tuxdriver.com, davem@davemloft.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
dsahern@kernel.org, rostedt@goodmis.org,
Menglong Dong <imagedong@tencent.com>
Subject: Re: [PATCH net-next] net: drop_monitor: support drop reason
Date: Tue, 25 Jan 2022 19:38:26 -0800 [thread overview]
Message-ID: <20220125193826.58ee023f@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> (raw)
In-Reply-To: <20220124075955.1232426-1-imagedong@tencent.com>
On Mon, 24 Jan 2022 15:59:55 +0800 menglong8.dong@gmail.com wrote:
> @@ -606,6 +608,7 @@ static int net_dm_packet_report_in_port_put(struct sk_buff *msg, int ifindex,
> static int net_dm_packet_report_fill(struct sk_buff *msg, struct sk_buff *skb,
> size_t payload_len)
> {
> + enum skb_drop_reason reason = NET_DM_SKB_CB(skb)->reason;
> u64 pc = (u64)(uintptr_t) NET_DM_SKB_CB(skb)->pc;
nit: maybe it's better to get a pointer to struct net_dm_skb_cb here
instead of local var for each field?
> char buf[NET_DM_MAX_SYMBOL_LEN];
> struct nlattr *attr;
> @@ -623,6 +626,9 @@ static int net_dm_packet_report_fill(struct sk_buff *msg, struct sk_buff *skb,
> if (nla_put_u64_64bit(msg, NET_DM_ATTR_PC, pc, NET_DM_ATTR_PAD))
> goto nla_put_failure;
>
> + if (nla_put_u32(msg, NET_DM_ATTR_REASON, reason))
> + goto nla_put_failure;
next prev parent reply other threads:[~2022-01-26 3:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 7:59 menglong8.dong
2022-01-26 3:38 ` Jakub Kicinski [this message]
2022-01-26 3:38 ` Menglong Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220125193826.58ee023f@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=imagedong@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=menglong8.dong@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®