From: tangmeng <tangmeng@uniontech.com>
To: axboe@kernel.dk, jejb@linux.ibm.com, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: tangmeng <tangmeng@uniontech.com>
Subject: [PATCH v2] scsi: sr: Improve the judgment statement
Date: Thu, 27 Jan 2022 17:11:36 +0800 [thread overview]
Message-ID: <20220127091136.9658-1-tangmeng@uniontech.com> (raw)
The previous code has a less-than-perfect usage of judgment syntax.
When the med->media_event_code value is equal to 2 or 3, the same
value is returned, so it would be better to combine the implementation
statements when the med->media_event_code value is equal to 2 or 3.
Moreover, when a variable is equal to multiple values, it is better
to use a switch judgment statement.
Signed-off-by: tangmeng <tangmeng@uniontech.com>
---
drivers/scsi/sr.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/sr.c b/drivers/scsi/sr.c
index f925b1f1f9ad..610baa630067 100644
--- a/drivers/scsi/sr.c
+++ b/drivers/scsi/sr.c
@@ -222,12 +222,16 @@ static unsigned int sr_get_events(struct scsi_device *sdev)
if (eh->nea || eh->notification_class != 0x4)
return 0;
- if (med->media_event_code == 1)
+ switch (med->media_event_code) {
+ case 1:
return DISK_EVENT_EJECT_REQUEST;
- else if (med->media_event_code == 2)
- return DISK_EVENT_MEDIA_CHANGE;
- else if (med->media_event_code == 3)
+ case 2:
+ case 3:
return DISK_EVENT_MEDIA_CHANGE;
+ default:
+ break;
+ }
+
return 0;
}
--
2.20.1
next reply other threads:[~2022-01-27 9:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 9:11 tangmeng [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-01-27 9:08 tangmeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220127091136.9658-1-tangmeng@uniontech.com \
--to=tangmeng@uniontech.com \
--cc=axboe@kernel.dk \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome