From: Laibin Qiu <qiulaibin@huawei.com>
To: <axboe@kernel.dk>, <andriy.shevchenko@linux.intel.com>
Cc: <linux-block@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<alex_y_xu@yahoo.ca>
Subject: [PATCH -next] blk-mq: Fix wrong wakeup batch configuration which will cause hang
Date: Thu, 27 Jan 2022 18:00:47 +0800 [thread overview]
Message-ID: <20220127100047.1763746-1-qiulaibin@huawei.com> (raw)
Commit 180dccb0dba4f ("blk-mq: fix tag_get wait task can't be
awakened") will recalculating wake_batch when inc or dec active_queues
to avoid wake_batch is > hctx_max_depth. At the same time, in order to
not affect performance as much as possible, the minimum wakeup batch is
set to 4. But when the QD is small (such as QD=1), if inc or dec
active_queues will increase wakeup batch, which will lead to hang.
Fix this problem with the following strategies:
QD : >= 32 | < 32
---------------------------------
wakeup batch: 8~4 | 3~1
Fixes: 180dccb0dba4f ("blk-mq: fix tag_get wait task can't be awakened")
Link: https://lore.kernel.org/linux-block/78cafe94-a787-e006-8851-69906f0c2128@huawei.com/T/#t
Reported-by: Alex Xu (Hello71) <alex_y_xu@yahoo.ca>
Signed-off-by: Laibin Qiu <qiulaibin@huawei.com>
---
lib/sbitmap.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/lib/sbitmap.c b/lib/sbitmap.c
index 6220fa67fb7e..09d293c30fd2 100644
--- a/lib/sbitmap.c
+++ b/lib/sbitmap.c
@@ -488,9 +488,13 @@ void sbitmap_queue_recalculate_wake_batch(struct sbitmap_queue *sbq,
unsigned int users)
{
unsigned int wake_batch;
+ unsigned int min_batch;
+ unsigned int depth = (sbq->sb.depth + users - 1) / users;
- wake_batch = clamp_val((sbq->sb.depth + users - 1) /
- users, 4, SBQ_WAKE_BATCH);
+ min_batch = sbq->sb.depth >= (4 * SBQ_WAIT_QUEUES) ? 4 : 1;
+
+ wake_batch = clamp_val(depth / SBQ_WAIT_QUEUES,
+ min_batch, SBQ_WAKE_BATCH);
__sbitmap_queue_update_wake_batch(sbq, wake_batch);
}
EXPORT_SYMBOL_GPL(sbitmap_queue_recalculate_wake_batch);
--
2.22.0
next reply other threads:[~2022-01-27 9:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 10:00 Laibin Qiu [this message]
2022-01-27 14:17 ` Alex Xu (Hello71)
2022-01-27 17:17 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220127100047.1763746-1-qiulaibin@huawei.com \
--to=qiulaibin@huawei.com \
--cc=alex_y_xu@yahoo.ca \
--cc=andriy.shevchenko@linux.intel.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®