From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35400C433F5 for ; Thu, 27 Jan 2022 11:21:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240197AbiA0LVs (ORCPT ); Thu, 27 Jan 2022 06:21:48 -0500 Received: from mga14.intel.com ([192.55.52.115]:52776 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240156AbiA0LVp (ORCPT ); Thu, 27 Jan 2022 06:21:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643282505; x=1674818505; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=TLkqMr2jx01CyRrqkRPNdsu/Li2EYBHMmZncYyPe5+g=; b=XZ/57Wrx9zxTL3nKfR9Xoh6ycaU3mq4OF/0RiX/Fhe4vE9zP2b8zCkOO QKWN5KyrqkmLOa05xz59O2yHgjAJTwWbyMTUrFwVs0tGBBi/X2Rw9ilt5 Gnpm9U6WPOQNCX6BgUFR6VXoD6EZ9yGohA6EI1tfvjTnn3EkvDktJJ3cb 7qqvjE7cXvNjxjDSecGCrjs+f4uX/6gwAr06JR+bt10gY803nU2zcPDIw txvZcOM1QmKLseUhlKPgQNYWaeo/c9klKanUmo9FMwzAyRE5pnoQLDe9S 0tvYdbru+/nxY/QCWzLa9t+wkFICzzGdljmZRkKczNJS/JXzJXElZLAsP Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10239"; a="247042428" X-IronPort-AV: E=Sophos;i="5.88,320,1635231600"; d="scan'208";a="247042428" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2022 03:21:44 -0800 X-IronPort-AV: E=Sophos;i="5.88,320,1635231600"; d="scan'208";a="480253250" Received: from sannilnx.jer.intel.com ([10.12.231.79]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2022 03:21:42 -0800 From: Alexander Usyskin To: Greg Kroah-Hartman , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , Daniel Vetter Cc: Tomas Winkler , Alexander Usyskin , Vitaly Lubart , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 3/5] mei: gsc: setup char driver alive in spite of firmware handshake failure Date: Thu, 27 Jan 2022 13:21:01 +0200 Message-Id: <20220127112103.2336871-4-alexander.usyskin@intel.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220127112103.2336871-1-alexander.usyskin@intel.com> References: <20220127112103.2336871-1-alexander.usyskin@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Setup char device in spite of firmware handshake failure. In order to provide host access to the firmware status registers and other information required for the manufacturing process. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/gsc-me.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/misc/mei/gsc-me.c b/drivers/misc/mei/gsc-me.c index 0afae70e0609..cf427f6fdec9 100644 --- a/drivers/misc/mei/gsc-me.c +++ b/drivers/misc/mei/gsc-me.c @@ -79,11 +79,12 @@ static int mei_gsc_probe(struct auxiliary_device *aux_dev, pm_runtime_set_active(device); pm_runtime_enable(device); - if (mei_start(dev)) { - dev_err(device, "init hw failure.\n"); - ret = -ENODEV; - goto err; - } + /* Continue to char device setup in spite of firmware handshake failure. + * In order to provide access to the firmware status registers to the user + * space via sysfs. + */ + if (mei_start(dev)) + dev_warn(device, "init hw failure.\n"); pm_runtime_set_autosuspend_delay(device, MEI_GSC_RPM_TIMEOUT); pm_runtime_use_autosuspend(device); -- 2.32.0