From: "Aleksa Vučković" <aleksav013@gmail.com>
To: gregkh@linuxfoundation.org
Cc: salah.triki@gmail.com, linux-kernel@vger.kernel.org,
"Aleksa Vučković" <aleksav013@gmail.com>
Subject: [PATCH 2/7] drivers: dio: brace should be on the previous line
Date: Thu, 27 Jan 2022 14:50:49 +0100 [thread overview]
Message-ID: <20220127135054.27281-2-aleksav013@gmail.com> (raw)
In-Reply-To: <20220127135054.27281-1-aleksav013@gmail.com>
This patch fixes the checkpatch.pl errors and warnings:
< ERROR: open brace '{' following struct go on the same line
< +struct dioname
< +{
<
< ERROR: that open brace { should be on the previous line
< +static struct dioname names[] =
< +{
<
< ERROR: that open brace { should be on the previous line
< + for (scode = 0; scode < DIO_SCMAX; ++scode)
< + {
<
< WARNING: braces {} are not necessary for any arm of this statement
< + if (scode >= DIOII_SCBASE) {
< [...]
< + } else if (scode > DIO_SCMAX || scode < 0)
< [...]
< + else if (DIO_SCINHOLE(scode))
< [...]
Signed-off-by: Aleksa Vučković <aleksav013@gmail.com>
---
drivers/dio/dio.c | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/dio/dio.c b/drivers/dio/dio.c
index 831f36ab6e2b..4a35ca2d0849 100644
--- a/drivers/dio/dio.c
+++ b/drivers/dio/dio.c
@@ -57,8 +57,7 @@ struct dio_bus dio_bus = {
* I think we do this by copying them into newly kmalloc()ed memory and
* marking the names[] array as .initdata ?
*/
-struct dioname
-{
+struct dioname {
int id;
const char *name;
};
@@ -67,8 +66,7 @@ struct dioname
#define DIONAME(x) { DIO_ID_##x, DIO_DESC_##x }
#define DIOFBNAME(x) { DIO_ENCODE_ID( DIO_ID_FBUFFER, DIO_ID2_##x), DIO_DESC2_##x }
-static struct dioname names[] =
-{
+static struct dioname names[] = {
DIONAME(DCA0), DIONAME(DCA0REM), DIONAME(DCA1), DIONAME(DCA1REM),
DIONAME(DCM), DIONAME(DCMREM),
DIONAME(LAN),
@@ -190,8 +188,7 @@ static int __init dio_init(void)
request_resource(&iomem_resource, &dio_bus.resources[i]);
/* Register all devices */
- for (scode = 0; scode < DIO_SCMAX; ++scode)
- {
+ for (scode = 0; scode < DIO_SCMAX; ++scode) {
u_char prid, secid = 0; /* primary, secondary ID bytes */
u_char *va;
unsigned long pa;
@@ -267,9 +264,9 @@ subsys_initcall(dio_init);
*/
unsigned long dio_scodetophysaddr(int scode)
{
- if (scode >= DIOII_SCBASE) {
+ if (scode >= DIOII_SCBASE)
return (DIOII_BASE + (scode - 132) * DIOII_DEVSIZE);
- } else if (scode > DIO_SCMAX || scode < 0)
+ else if (scode > DIO_SCMAX || scode < 0)
return 0;
else if (DIO_SCINHOLE(scode))
return 0;
--
2.35.0
next prev parent reply other threads:[~2022-01-27 13:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 13:50 [PATCH 1/7] drivers: dio: Use <linux/io.h> instead <asm/io.h> Aleksa Vučković
2022-01-27 13:50 ` Aleksa Vučković [this message]
2022-01-27 13:50 ` [PATCH 3/7] drivers: dio: trailing whitespace Aleksa Vučković
2022-01-27 13:50 ` [PATCH 4/7] drivers: dio: space prohibited after parenthesis Aleksa Vučković
2022-01-27 13:50 ` [PATCH 5/7] drivers: dio: space required after that ',' Aleksa Vučković
2022-01-27 13:50 ` [PATCH 6/7] drivers: dio: code indent should use tabs Aleksa Vučković
2022-01-27 13:50 ` [PATCH 7/7] drivers: Missing a blank line after declarations Aleksa Vučković
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220127135054.27281-2-aleksav013@gmail.com \
--to=aleksav013@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=salah.triki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome