From: Sean Anderson <sean.anderson@seco.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org
Cc: Robert Hancock <robert.hancock@calian.com>,
Baruch Siach <baruch@tkos.co.il>, Felipe Balbi <balbi@kernel.org>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
linux-kernel@vger.kernel.org,
Balaji Prakash J <bjagadee@codeaurora.org>,
Sean Anderson <sean.anderson@seco.com>
Subject: [PATCH v3 5/7] usb: dwc3: Add snps,ref-clock-frequency-hz property for ACPI
Date: Thu, 27 Jan 2022 15:06:34 -0500 [thread overview]
Message-ID: <20220127200636.1456175-6-sean.anderson@seco.com> (raw)
In-Reply-To: <20220127200636.1456175-1-sean.anderson@seco.com>
This property allows setting the reference clock frequency properly for
ACPI-based systems. It is not documented under dt-bindings, since it is
not intended for use on DT-based systems. DT-based systems should use
the clocks property instead.
Frequency is preferred over period since it has greater precision when
used in calculations.
Signed-off-by: Sean Anderson <sean.anderson@seco.com>
---
(no changes since v2)
Changes in v2:
- New
drivers/usb/dwc3/core.c | 6 ++++--
drivers/usb/dwc3/core.h | 4 +++-
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 18adddfba3da..c1b045121672 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -353,8 +353,8 @@ static void dwc3_ref_clk_period(struct dwc3 *dwc)
unsigned long rate;
u32 reg;
- if (dwc->ref_clk) {
- rate = clk_get_rate(dwc->ref_clk);
+ if (dwc->ref_clk || dwc->ref_clk_freq) {
+ rate = clk_get_rate(dwc->ref_clk) ?: dwc->ref_clk_freq;
if (!rate)
return;
period = NSEC_PER_SEC / rate;
@@ -1497,6 +1497,8 @@ static void dwc3_get_properties(struct dwc3 *dwc)
&dwc->fladj);
device_property_read_u32(dev, "snps,ref-clock-period-ns",
&dwc->ref_clk_per);
+ device_property_read_u32(dev, "snps,ref-clock-frequency-hz",
+ &dwc->ref_clk_freq);
dwc->dis_metastability_quirk = device_property_read_bool(dev,
"snps,dis_metastability_quirk");
diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index eb9c1efced05..00a792459fec 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -988,7 +988,8 @@ struct dwc3_scratchpad_array {
* @regs: base address for our registers
* @regs_size: address space size
* @fladj: frame length adjustment
- * @ref_clk_per: reference clock period configuration
+ * @ref_clk_per: reference clock period; deprecated in favor of @ref_clk_freq
+ * @ref_clk_freq: reference clock frequency to use if @ref_clk is missing
* @irq_gadget: peripheral controller's IRQ number
* @otg_irq: IRQ number for OTG IRQs
* @current_otg_role: current role of operation while using the OTG block
@@ -1171,6 +1172,7 @@ struct dwc3 {
u32 fladj;
u32 ref_clk_per;
+ u32 ref_clk_freq;
u32 irq_gadget;
u32 otg_irq;
u32 current_otg_role;
--
2.25.1
next prev parent reply other threads:[~2022-01-27 20:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 20:06 [PATCH v3 0/7] usb: dwc3: Calculate REFCLKPER et. al. from reference clock Sean Anderson
2022-01-27 20:06 ` [PATCH v3 1/7] dt-bindings: usb: dwc3: Deprecate snps,ref-clock-period-ns Sean Anderson
2022-02-07 21:27 ` Rob Herring
2022-01-27 20:06 ` [PATCH v3 2/7] usb: dwc3: Get clocks individually Sean Anderson
2022-01-27 20:06 ` [PATCH v3 3/7] usb: dwc3: Calculate REFCLKPER based on reference clock Sean Anderson
2022-02-03 3:09 ` Thinh Nguyen
2022-01-27 20:06 ` [PATCH v3 4/7] usb: dwc3: Program GFLADJ Sean Anderson
2022-02-03 3:10 ` Thinh Nguyen
2022-01-27 20:06 ` Sean Anderson [this message]
2022-02-03 3:11 ` [PATCH v3 5/7] usb: dwc3: Add snps,ref-clock-frequency-hz property for ACPI Thinh Nguyen
[not found] ` <CAHp75Vc--RYW7P0wLA8Jcr53xKSkphJV=wTeZiPC-AYu4sGYFA@mail.gmail.com>
2022-02-04 16:00 ` Sean Anderson
2022-02-04 18:38 ` Andy Shevchenko
2022-02-04 18:44 ` Sean Anderson
2022-02-04 19:24 ` Andy Shevchenko
2022-01-27 20:06 ` [PATCH v3 6/7] arm64: dts: zynqmp: Move USB clocks to dwc3 node Sean Anderson
2022-01-27 20:06 ` [PATCH v3 7/7] arm64: dts: ipq6018: Use reference clock to set dwc3 period Sean Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220127200636.1456175-6-sean.anderson@seco.com \
--to=sean.anderson@seco.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=balbi@kernel.org \
--cc=baruch@tkos.co.il \
--cc=bjagadee@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robert.hancock@calian.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®