mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@kernel.org>
To: torvalds@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, rcu@vger.kernel.org,
	andrii.nakryiko@gmail.com, kafai@fb.com, neeraj.iitr10@gmail.com,
	Mark.Rutland@arm.com, hca@linux.ibm.com, kernel-team@fb.com
Subject: [GIT PULL] RCU Tasks fix for systems with non-power-of-two numbers of CPUs
Date: Fri, 28 Jan 2022 06:32:51 -0800	[thread overview]
Message-ID: <20220128143251.GA2398275@paulmck-ThinkPad-P17-Gen-1> (raw)

Hello, Linus,

This pull request fixes a brown-paper-bag bug in RCU tasks that
causes things like BPF and ftrace to fail miserably on systems with
non-power-of-two numbers of CPUs.

And yes, I will be adding non-power-of-two scenarios to rcutorture,
in case you were wondering.  But that can wait for v5.19.

The following changes since commit e783362eb54cd99b2cac8b3a9aeac942e6f6ac07:

  Linux 5.17-rc1 (2022-01-23 10:12:53 +0200)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git tags/rcu-urgent.2022.01.26a

for you to fetch changes up to da123016ca8cb5697366c0b2dd55059b976e67e4:

  rcu-tasks: Fix computation of CPU-to-list shift counts (2022-01-26 13:04:05 -0800)

----------------------------------------------------------------
Urgent RCU pull request for v5.17

This pull request fixes a math error added in 7a30871b6a27 ("rcu-tasks:
Introduce ->percpu_enqueue_shift for dynamic queue selection') during the
v5.17 merge window.  This commit works correctly only on systems with a
power-of-two number of CPUs, which just so happens to be the kind that
rcutorture always uses by default.

This pull request fixes the math so that things also work on systems
that don't happen to have a power-of-two number of CPUs.

----------------------------------------------------------------
Paul E. McKenney (1):
      rcu-tasks: Fix computation of CPU-to-list shift counts

 kernel/rcu/tasks.h | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

             reply	other threads:[~2022-01-28 14:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-28 14:32 Paul E. McKenney [this message]
2022-01-28 17:35 ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220128143251.GA2398275@paulmck-ThinkPad-P17-Gen-1 \
    --to=paulmck@kernel.org \
    --cc=Mark.Rutland@arm.com \
    --cc=andrii.nakryiko@gmail.com \
    --cc=hca@linux.ibm.com \
    --cc=kafai@fb.com \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neeraj.iitr10@gmail.com \
    --cc=rcu@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®